svelte-kit-vice

Commit Graph

Author	SHA1	Message	Date
dev	cc0d38ec52	refactor(floating): extract createFloatingShellRoot + buildFloatingShellWrapperProps helpers (audit Round 3 §3 #1 ) 7 popover-based soma providers (popover, dropdown-menu, context-menu, combobox, select, tooltip, link-preview) shared two byte-identical blocks that an investigation report (delegated Plan agent) confirmed as real duplication after looking carefully past the audit's headline "600 lines across 15 providers" — the actual scope was ~230 lines across 7 providers (the audit overcounted by ~2x, similar to the BaseSegmentProvider case). Two narrow helpers added in `src/uix/soma/layers/floating/shell.ts`: - `createFloatingShellRoot({ dom, open, contentRef, onOpenChangeComplete })` bundles `FloatingProvider.create({ dom })` + the `contentPresence` constructor (which were verbatim across all 7 providers, byte for byte). Returns `{ floatingProvider, contentPresence }` the consumer assigns to `this.*` fields. - `buildFloatingShellWrapperProps(floating, pointerEvents = 'auto')` returns the canonical wrapperProps shape (spread floating's wrapperProps + `style.pointer-events` forced to a value). Identical in 6 of 7; tooltip parameterises `pointerEvents` to flip on `hoverableDisabled`. Explicitly NOT abstracted: FocusScope, Dismissal, ScrollLock, TextSelection — these look similar but diverge per provider (modal- derived `trap`, custom `isValidEvent` closures, different close callbacks — see Round 3 audit analysis). Trying to hide them would recreate the BaseSegmentProvider trap of flag bloat. Notable variations preserved: - popover keeps its `overlayPresence` (popover-only chrome) outside the shell helper — only `contentPresence` is shared. - context-menu's SubContent sub-provider also uses the same wrapper helper (its FloatingProvider.create stays inline because it reads `this.provider.soma.dom` not `this.soma.dom`). - dropdown-menu has both a Content and SubContent wrapperProps — both routed through the helper. Test result: 2394/2399 passing — no regressions in the 27 tests across the 7 affected providers. The 5 fails remain Words + cookie infra (cookie is flaky; sometimes 6, sometimes 5). Closes the last item of Kim audit Round 3 §3. Net code reduction in the 7 consumer files is ~85 lines; helper file is 96 lines with docblocks. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	5 months ago

Author

SHA1

Message

Date

dev

cc0d38ec52

refactor(floating): extract createFloatingShellRoot + buildFloatingShellWrapperProps helpers (audit Round 3 §3 #1 )

7 popover-based soma providers (popover, dropdown-menu, context-menu,
combobox, select, tooltip, link-preview) shared two byte-identical
blocks that an investigation report (delegated Plan agent) confirmed
as real duplication after looking carefully past the audit's headline
"600 lines across 15 providers" — the actual scope was ~230 lines
across 7 providers (the audit overcounted by ~2x, similar to the
BaseSegmentProvider case).

Two narrow helpers added in `src/uix/soma/layers/floating/shell.ts`:

  - `createFloatingShellRoot({ dom, open, contentRef, onOpenChangeComplete })`
    bundles `FloatingProvider.create({ dom })` + the `contentPresence`
    constructor (which were verbatim across all 7 providers, byte for
    byte). Returns `{ floatingProvider, contentPresence }` the consumer
    assigns to `this.*` fields.

  - `buildFloatingShellWrapperProps(floating, pointerEvents = 'auto')`
    returns the canonical wrapperProps shape (spread floating's
    wrapperProps + `style.pointer-events` forced to a value). Identical
    in 6 of 7; tooltip parameterises `pointerEvents` to flip on
    `hoverableDisabled`.

Explicitly NOT abstracted: FocusScope, Dismissal, ScrollLock,
TextSelection — these look similar but diverge per provider (modal-
derived `trap`, custom `isValidEvent` closures, different close
callbacks — see Round 3 audit analysis). Trying to hide them would
recreate the BaseSegmentProvider trap of flag bloat.

Notable variations preserved:
  - popover keeps its `overlayPresence` (popover-only chrome) outside
    the shell helper — only `contentPresence` is shared.
  - context-menu's SubContent sub-provider also uses the same wrapper
    helper (its FloatingProvider.create stays inline because it reads
    `this.provider.soma.dom` not `this.soma.dom`).
  - dropdown-menu has both a Content and SubContent wrapperProps —
    both routed through the helper.

Test result: 2394/2399 passing — no regressions in the 27 tests
across the 7 affected providers. The 5 fails remain Words + cookie
infra (cookie is flaky; sometimes 6, sometimes 5).

Closes the last item of Kim audit Round 3 §3. Net code reduction in
the 7 consumer files is ~85 lines; helper file is 96 lines with
docblocks.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1 Commits (cc0d38ec5213a8cb126fd30c8340c14040a7236d)