svelte-kit-vice

Commit Graph

Author	SHA1	Message	Date
dev	d797a0cebc	feat(motion): M9 F1c+F2 — dropdown-menu item cascade (children-DOM) F1c (exit-heavy): DomCascade.pending() aggregates the items' finished so the owner Presence holds the subtree until the exit cascade settles (PresenceOptions.pending, Presence.startPhase). beginEnter drives the enter from the off-state with the transition suppressed (items mount in the on-state, so a passive mirror would ease toward off instead of jumping). pending() settles each finisher (then(noop,noop)) so one cancelled row can't collapse the wait. F2: wire the children-DOM cascade into the real dropdown-menu. Content part declares animation.surface+staggerChildren; provider routes an opt-in 'animation' prop, runs a DomCascade over getCascadeRows (every visible row incl. disabled), forwards a pending hook through the floating shell. Coexistence fixes surfaced by the menu: item rows hand their transition to the cascade-* preset via a higher-specificity rule (longhands keep the stagger delay); disabled opacity gated off during the cascade; the panel's own dismiss-fade signature suppressed in cascade mode (data-cascade) so it doesn't fade the panel before the rows finish; the trigger is excluded from the menu's dismissal so the toggle closes (pre-existing bug). Verified in a real browser (Playwright): enter+exit cascade with reversed stagger, all four close methods, disabled row fades. dom-cascade 9/9, check 0 new errors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	4 months ago
dev	546aa8d0ee	fix(soma/eidos): close last 5 check errors — PassthroughProps helper + floating/shell cast `npm run check`: 5 errors → 0 errors. floating/shell.ts (Phase 1 — local fix): - `buildFloatingShellWrapperProps` returned a type where TS couldn't prove `transform` stayed required after the conditional-object spread. Runtime preserves the key; we cast at the return boundary so consumers downstream keep the strict shape. soma/types/html.ts (Phase 2 — canonical pattern): - Nuevo `PassthroughProps<T>` helper para resolver el drift Eidos→Soma estructuralmente. Es `Omit<HTMLAttributes<T>, 'style' \| 'id' \| 'children' \| 'dir' \| 'value' \| 'placeholder'>`. Las keys excluidas son las que Soma narrowa en sus Provider types — incluirlas en Eidos wrappers (via el plain `HTMLAttributes<T>`) producía "Expression produces a union type that is too complex to represent" y errores de incompatibilidad al hacer spread. - Exportado por `soma/types/index.ts`. eidos picker views (Phase 3 — adopción): - `date-picker-year-view.svelte` y `date-picker-month-view.svelte` tipados como `Props = PassthroughProps<HTMLDivElement>` en lugar del plain `HTMLAttributes<HTMLDivElement>`. Conserva data-, aria-, class, role, tabindex etc. — solo dropea las keys conflictivas. Pattern reusable: cualquier futuro Eidos wrapper que envuelva un Soma Provider via `{...props}` debe usar `PassthroughProps<T>` en vez de `HTMLAttributes<T>`. Documentado en el JSDoc del helper con ejemplo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	5 months ago
dev	cc0d38ec52	refactor(floating): extract createFloatingShellRoot + buildFloatingShellWrapperProps helpers (audit Round 3 §3 #1 ) 7 popover-based soma providers (popover, dropdown-menu, context-menu, combobox, select, tooltip, link-preview) shared two byte-identical blocks that an investigation report (delegated Plan agent) confirmed as real duplication after looking carefully past the audit's headline "600 lines across 15 providers" — the actual scope was ~230 lines across 7 providers (the audit overcounted by ~2x, similar to the BaseSegmentProvider case). Two narrow helpers added in `src/uix/soma/layers/floating/shell.ts`: - `createFloatingShellRoot({ dom, open, contentRef, onOpenChangeComplete })` bundles `FloatingProvider.create({ dom })` + the `contentPresence` constructor (which were verbatim across all 7 providers, byte for byte). Returns `{ floatingProvider, contentPresence }` the consumer assigns to `this.*` fields. - `buildFloatingShellWrapperProps(floating, pointerEvents = 'auto')` returns the canonical wrapperProps shape (spread floating's wrapperProps + `style.pointer-events` forced to a value). Identical in 6 of 7; tooltip parameterises `pointerEvents` to flip on `hoverableDisabled`. Explicitly NOT abstracted: FocusScope, Dismissal, ScrollLock, TextSelection — these look similar but diverge per provider (modal- derived `trap`, custom `isValidEvent` closures, different close callbacks — see Round 3 audit analysis). Trying to hide them would recreate the BaseSegmentProvider trap of flag bloat. Notable variations preserved: - popover keeps its `overlayPresence` (popover-only chrome) outside the shell helper — only `contentPresence` is shared. - context-menu's SubContent sub-provider also uses the same wrapper helper (its FloatingProvider.create stays inline because it reads `this.provider.soma.dom` not `this.soma.dom`). - dropdown-menu has both a Content and SubContent wrapperProps — both routed through the helper. Test result: 2394/2399 passing — no regressions in the 27 tests across the 7 affected providers. The 5 fails remain Words + cookie infra (cookie is flaky; sometimes 6, sometimes 5). Closes the last item of Kim audit Round 3 §3. Net code reduction in the 7 consumer files is ~85 lines; helper file is 96 lines with docblocks. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	5 months ago

Author

SHA1

Message

Date

dev

d797a0cebc

feat(motion): M9 F1c+F2 — dropdown-menu item cascade (children-DOM)

F1c (exit-heavy): DomCascade.pending() aggregates the items' finished so the owner Presence holds the subtree until the exit cascade settles (PresenceOptions.pending, Presence.startPhase). beginEnter drives the enter from the off-state with the transition suppressed (items mount in the on-state, so a passive mirror would ease toward off instead of jumping). pending() settles each finisher (then(noop,noop)) so one cancelled row can't collapse the wait.

F2: wire the children-DOM cascade into the real dropdown-menu. Content part declares animation.surface+staggerChildren; provider routes an opt-in 'animation' prop, runs a DomCascade over getCascadeRows (every visible row incl. disabled), forwards a pending hook through the floating shell. Coexistence fixes surfaced by the menu: item rows hand their transition to the cascade-* preset via a higher-specificity rule (longhands keep the stagger delay); disabled opacity gated off during the cascade; the panel's own dismiss-fade signature suppressed in cascade mode (data-cascade) so it doesn't fade the panel before the rows finish; the trigger is excluded from the menu's dismissal so the toggle closes (pre-existing bug). Verified in a real browser (Playwright): enter+exit cascade with reversed stagger, all four close methods, disabled row fades. dom-cascade 9/9, check 0 new errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

dev

546aa8d0ee

fix(soma/eidos): close last 5 check errors — PassthroughProps helper + floating/shell cast

`npm run check`: 5 errors → 0 errors.

floating/shell.ts (Phase 1 — local fix):
- `buildFloatingShellWrapperProps` returned a type where TS couldn't
  prove `transform` stayed required after the conditional-object
  spread. Runtime preserves the key; we cast at the return boundary so
  consumers downstream keep the strict shape.

soma/types/html.ts (Phase 2 — canonical pattern):
- Nuevo `PassthroughProps<T>` helper para resolver el drift Eidos→Soma
  estructuralmente. Es `Omit<HTMLAttributes<T>, 'style' | 'id' |
  'children' | 'dir' | 'value' | 'placeholder'>`. Las keys excluidas son
  las que Soma narrowa en sus Provider types — incluirlas en Eidos
  wrappers (via el plain `HTMLAttributes<T>`) producía "Expression
  produces a union type that is too complex to represent" y errores de
  incompatibilidad al hacer spread.
- Exportado por `soma/types/index.ts`.

eidos picker views (Phase 3 — adopción):
- `date-picker-year-view.svelte` y `date-picker-month-view.svelte`
  tipados como `Props = PassthroughProps<HTMLDivElement>` en lugar del
  plain `HTMLAttributes<HTMLDivElement>`. Conserva data-*, aria-*,
  class, role, tabindex etc. — solo dropea las keys conflictivas.

Pattern reusable: cualquier futuro Eidos wrapper que envuelva un Soma
Provider via `{...props}` debe usar `PassthroughProps<T>` en vez de
`HTMLAttributes<T>`. Documentado en el JSDoc del helper con ejemplo.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

dev

cc0d38ec52

refactor(floating): extract createFloatingShellRoot + buildFloatingShellWrapperProps helpers (audit Round 3 §3 #1 )

7 popover-based soma providers (popover, dropdown-menu, context-menu,
combobox, select, tooltip, link-preview) shared two byte-identical
blocks that an investigation report (delegated Plan agent) confirmed
as real duplication after looking carefully past the audit's headline
"600 lines across 15 providers" — the actual scope was ~230 lines
across 7 providers (the audit overcounted by ~2x, similar to the
BaseSegmentProvider case).

Two narrow helpers added in `src/uix/soma/layers/floating/shell.ts`:

  - `createFloatingShellRoot({ dom, open, contentRef, onOpenChangeComplete })`
    bundles `FloatingProvider.create({ dom })` + the `contentPresence`
    constructor (which were verbatim across all 7 providers, byte for
    byte). Returns `{ floatingProvider, contentPresence }` the consumer
    assigns to `this.*` fields.

  - `buildFloatingShellWrapperProps(floating, pointerEvents = 'auto')`
    returns the canonical wrapperProps shape (spread floating's
    wrapperProps + `style.pointer-events` forced to a value). Identical
    in 6 of 7; tooltip parameterises `pointerEvents` to flip on
    `hoverableDisabled`.

Explicitly NOT abstracted: FocusScope, Dismissal, ScrollLock,
TextSelection — these look similar but diverge per provider (modal-
derived `trap`, custom `isValidEvent` closures, different close
callbacks — see Round 3 audit analysis). Trying to hide them would
recreate the BaseSegmentProvider trap of flag bloat.

Notable variations preserved:
  - popover keeps its `overlayPresence` (popover-only chrome) outside
    the shell helper — only `contentPresence` is shared.
  - context-menu's SubContent sub-provider also uses the same wrapper
    helper (its FloatingProvider.create stays inline because it reads
    `this.provider.soma.dom` not `this.soma.dom`).
  - dropdown-menu has both a Content and SubContent wrapperProps —
    both routed through the helper.

Test result: 2394/2399 passing — no regressions in the 27 tests
across the 7 affected providers. The 5 fails remain Words + cookie
infra (cookie is flaky; sometimes 6, sometimes 5).

Closes the last item of Kim audit Round 3 §3. Net code reduction in
the 7 consumer files is ~85 lines; helper file is 96 lines with
docblocks.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

3 Commits (b8637976a01a1cf67edeadf7ec0044c0a187cffd)