svelte-kit-vice

Commit Graph

Author	SHA1	Message	Date
dev	194ca208f9	feat(words): R3 — render-v2 + HTML + MD serializers + 56 tests R3 closes the pure-V2 output path. Take a WordsDocumentV2 and turn it into either an abstract render tree (for Eidos/React/Vue/vanilla to walk), an HTML string with inline styles (roundtrip-friendly), or a Markdown string (lossy by design — visual.* dropped). engine/render-v2.ts (~370 lines): - Pure renderWordsDocumentV2(doc) → readonly WordsRenderElementV2[]. - WordsRenderNodeV2 is a superset of V1's WordsRenderNode (adds 'hr', 'div', 'section' tags for divider / callout). V1 stays untouched. - Per-block dispatch for all 9 V2 types (paragraph/heading/quote/code/ list/table/image/divider/callout). Same node shape as V1 — Svelte walker doesn't need changes. - visualToStyle(visual) helper exports the central translation from BlockVisual props to CSS declarations. Numbers get 'px', hex strings pass through. borderColor without borderWidth defaults to 1px solid. - Mark wrapping: parametric color/background marks combine into one <span style="...">; boolean marks stack via <code>/<span> with data-words-mark attr + inline style fallback. - Callout renders as <div role="note" data-words-callout-intent="X"> with optional title block + nested children. engine/serialize-html-v2.ts (~120 lines): - Pure serializeHtmlV2(doc, { pretty? }) → string. - Walks renderWordsDocumentV2 output and emits escaped HTML. - Properly escapes &, <, > in text; &, <, >, " in attribute values. - Void elements (img/hr/br/input/meta/link) emit self-closing form. - Pretty mode (opt-in) indents nested elements with 2 spaces. - Roundtrip-friendly: inline style="..." preserves visual.* lossless. engine/serialize-markdown-v2.ts (~190 lines): - Pure serializeMarkdownV2(doc) → string. - LOSSY by design (D-Q2): visual.* dropped entirely; color/background marks dropped (no MD vocabulary); underline mark dropped. - Preserves structural semantics: headings (# ## ###), quotes (>), code blocks (``` with language fence), lists (- / 1. / - [x] - [ ] GFM task lists), tables (GFM with :--- / :---: / ---: alignment), images (![alt](src "caption")), dividers (---), callouts (GFM admonitions via INTENT_TO_GFM_ADMONITION mapping). - INTENT_TO_GFM_ADMONITION exported: P7 boundary mapping — neutral→NOTE, affirm→TIP, fulfill→IMPORTANT, risk→WARNING, threat→CAUTION, loss→CAUTION. - Mark order in output: bold(*) outer → italic() → strike(~~) → code(`) inner. - Cells escape \| as \\| to avoid GFM table parser confusion. Tests (56 new): - render-v2.test.ts (23 tests): basic blocks, visual sidecar with exact style strings, table headerRow/headerCol semantics, marks rendering, path encoding, visualToStyle direct. - serialize-html-v2.test.ts (12 tests): paragraph, escape semantics, void elements, inline styles, callout role attr, pretty mode, table th/td. - serialize-markdown-v2.test.ts (21 tests): every block type, marks, visual.* dropped (lossy), callout intent → admonition tag mapping (all 6 SemaIntent values), link with title, table cell \| escaping. Important deferral: POLISH-1b (image radius/shadow/border slider) needs the provider to write block.visual.*. Provider is V1 internally. Deferred to R5 (after R4 migrates provider to V2). Pure render path is ready when provider catches up. Verification: 226/226 engine tests pass (85 V1 + 50 V2 validator + 35 V2 migrator/parity + 56 V2 render/serializers). `npm run check`: 0 errors. V1 model + render path UNTOUCHED — V2 lives in parallel. Next: R4 — provider V2 migration. Operations rewritten over WordsBlockV2. Runtime imageStatus sidecar wired at mount. Public API preserved via adapter during transition. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	4 months ago

Author

SHA1

Message

Date

dev

194ca208f9

feat(words): R3 — render-v2 + HTML + MD serializers + 56 tests

R3 closes the pure-V2 output path. Take a WordsDocumentV2 and turn it
into either an abstract render tree (for Eidos/React/Vue/vanilla to
walk), an HTML string with inline styles (roundtrip-friendly), or a
Markdown string (lossy by design — visual.* dropped).

engine/render-v2.ts (~370 lines):
- Pure renderWordsDocumentV2(doc) → readonly WordsRenderElementV2[].
- WordsRenderNodeV2 is a superset of V1's WordsRenderNode (adds 'hr',
  'div', 'section' tags for divider / callout). V1 stays untouched.
- Per-block dispatch for all 9 V2 types (paragraph/heading/quote/code/
  list/table/image/divider/callout). Same node shape as V1 — Svelte
  walker doesn't need changes.
- visualToStyle(visual) helper exports the central translation from
  BlockVisual props to CSS declarations. Numbers get 'px', hex strings
  pass through. borderColor without borderWidth defaults to 1px solid.
- Mark wrapping: parametric color/background marks combine into one
  <span style="...">; boolean marks stack via <code>/<span> with
  data-words-mark attr + inline style fallback.
- Callout renders as <div role="note" data-words-callout-intent="X">
  with optional title block + nested children.

engine/serialize-html-v2.ts (~120 lines):
- Pure serializeHtmlV2(doc, { pretty? }) → string.
- Walks renderWordsDocumentV2 output and emits escaped HTML.
- Properly escapes &, <, > in text; &, <, >, " in attribute values.
- Void elements (img/hr/br/input/meta/link) emit self-closing form.
- Pretty mode (opt-in) indents nested elements with 2 spaces.
- Roundtrip-friendly: inline style="..." preserves visual.* lossless.

engine/serialize-markdown-v2.ts (~190 lines):
- Pure serializeMarkdownV2(doc) → string.
- LOSSY by design (D-Q2): visual.* dropped entirely; color/background
  marks dropped (no MD vocabulary); underline mark dropped.
- Preserves structural semantics: headings (# ## ###), quotes (>),
  code blocks (``` with language fence), lists (- / 1. / - [x] - [ ]
  GFM task lists), tables (GFM with :--- / :---: / ---: alignment),
  images (![alt](src "caption")), dividers (---), callouts (GFM
  admonitions via INTENT_TO_GFM_ADMONITION mapping).
- INTENT_TO_GFM_ADMONITION exported: P7 boundary mapping —
  neutral→NOTE, affirm→TIP, fulfill→IMPORTANT, risk→WARNING,
  threat→CAUTION, loss→CAUTION.
- Mark order in output: bold(**) outer → italic(*) → strike(~~) →
  code(`) inner.
- Cells escape | as \| to avoid GFM table parser confusion.

Tests (56 new):
- render-v2.test.ts (23 tests): basic blocks, visual sidecar with
  exact style strings, table headerRow/headerCol semantics, marks
  rendering, path encoding, visualToStyle direct.
- serialize-html-v2.test.ts (12 tests): paragraph, escape semantics,
  void elements, inline styles, callout role attr, pretty mode,
  table th/td.
- serialize-markdown-v2.test.ts (21 tests): every block type, marks,
  visual.* dropped (lossy), callout intent → admonition tag mapping
  (all 6 SemaIntent values), link with title, table cell | escaping.

Important deferral: POLISH-1b (image radius/shadow/border slider)
needs the provider to write block.visual.*. Provider is V1 internally.
Deferred to R5 (after R4 migrates provider to V2). Pure render path
is ready when provider catches up.

Verification: 226/226 engine tests pass (85 V1 + 50 V2 validator +
35 V2 migrator/parity + 56 V2 render/serializers). `npm run check`:
0 errors. V1 model + render path UNTOUCHED — V2 lives in parallel.

Next: R4 — provider V2 migration. Operations rewritten over
WordsBlockV2. Runtime imageStatus sidecar wired at mount. Public API
preserved via adapter during transition.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1 Commits (194ca208f96578a4fddb7a8f7e26d8746154be52)