From f3dadd0be708674598d6e5e74d0b580bb9f68c92 Mon Sep 17 00:00:00 2001 From: dev Date: Fri, 15 May 2026 23:52:27 +0200 Subject: [PATCH] Add accordion provider coverage --- continue.md | 5 +- src/uix/soma/SOMA_ARCHITECTURE.md | 8 +- .../accordion-provider.svelte.test.ts | 282 ++++++++++++++++++ 3 files changed, 291 insertions(+), 4 deletions(-) create mode 100644 src/uix/soma/components/accordion/accordion-provider.svelte.test.ts diff --git a/continue.md b/continue.md index 902763f70..040b7a85d 100644 --- a/continue.md +++ b/continue.md @@ -74,9 +74,11 @@ Actualizacion 2026-05-15: typeahead, indicador de item y grupos. - Cobertura nueva para TreeView: expansión/selección, navegación root, typeahead, props de ramas/hojas y partes auxiliares. + - Cobertura nueva para Accordion: modo single/multiple, eventos open/close + por item, navegación de triggers y props de header/content. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - - `npm run test` -> 197 archivos, 2133 tests OK. + - `npm run test` -> 198 archivos, 2137 tests OK. - tests focales de Select/Popover/Toast/RangeCalendar -> 11 tests OK. - tests focales Dialog/Drawer/Popover/Select -> 10 tests OK. - `command-provider.svelte.test.ts` -> 2 tests OK. @@ -102,6 +104,7 @@ Actualizacion 2026-05-15: - `menubar-provider.svelte.test.ts` -> 4 tests OK. - `listbox-provider.svelte.test.ts` -> 4 tests OK. - `tree-view-provider.svelte.test.ts` -> 4 tests OK. + - `accordion-provider.svelte.test.ts` -> 4 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index bb32b6a01..6b7a8d1c7 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -506,12 +506,14 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A navegación, typeahead, indicador de item y grupos. - `tree-view/tree-view-provider.svelte.test.ts` — expansión/selección, navegación root, typeahead, props de ramas/hojas y partes auxiliares. +- `accordion/accordion-provider.svelte.test.ts` — modos single/multiple, + eventos `open/close` por item, navegación de triggers y header/content. Pendiente: seguir ampliando cobertura por familias de alto riesgo fuera del bloque fecha/hora, virtualización, inputs numericos, file upload, color y -navegacion superior/treegrid/tree-view/dropdown/context-menu/menubar/listbox. -`table-core`, `form-core` y el scorer de Command ya no viven dentro de Soma: -se consumen desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. +navegacion superior/treegrid/tree-view/dropdown/context-menu/menubar/listbox/ +accordion. `table-core`, `form-core` y el scorer de Command ya no viven dentro +de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. ### Convencion diff --git a/src/uix/soma/components/accordion/accordion-provider.svelte.test.ts b/src/uix/soma/components/accordion/accordion-provider.svelte.test.ts new file mode 100644 index 000000000..b537c1549 --- /dev/null +++ b/src/uix/soma/components/accordion/accordion-provider.svelte.test.ts @@ -0,0 +1,282 @@ +// @vitest-environment jsdom + +import { tick } from 'svelte'; +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; + +import { + AccordionContentProvider, + AccordionHeaderProvider, + AccordionItemProvider, + AccordionProvider, + AccordionTriggerProvider +} from './accordion-provider.svelte'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness() { + const dom = createActiveDom(); + const logger = { + warn: vi.fn() + }; + const soma = { + dom, + logger, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(AccordionProvider.ctx, 'set').mockImplementation((value) => value); + vi.spyOn(AccordionItemProvider.ctx, 'set').mockImplementation((value) => value); + + return { dom, logger }; +} + +function createAccordionOpts(root = document.createElement('div')) { + root.setAttribute('data-accordion', ''); + document.body.appendChild(root); + return { + id: state('accordion-root'), + ref: state(root), + value: state([]), + type: state<'single' | 'multiple'>('single'), + collapsible: state(false), + disabled: state(false), + orientation: state<'horizontal' | 'vertical'>('vertical'), + loop: state(false), + dir: state<'ltr' | 'rtl'>('ltr'), + region: state(true) + }; +} + +function itemOpts(id: string, value: string, el = document.createElement('div'), disabled = false) { + return { + id: state(id), + ref: state(el), + value: state(value), + disabled: state(disabled) + }; +} + +function partOpts(id: string, el: HTMLElement) { + return { + id: state(id), + ref: state(el) + }; +} + +function applyAttrs(el: HTMLElement, props: Record) { + for (const [key, value] of Object.entries(props)) { + if ( + !key.startsWith('data-') && + !key.startsWith('aria-') && + key !== 'role' && + key !== 'id' && + key !== 'disabled' && + key !== 'type' + ) { + continue; + } + if (value === undefined || value === false || typeof value === 'function') continue; + el.setAttribute(key, value === true ? '' : String(value)); + } +} + +function keyEvent(key: string, currentTarget: HTMLButtonElement) { + return { + key, + currentTarget, + preventDefault: vi.fn() + }; +} + +describe('AccordionProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('coordinates single-item open state and emits item toggle events', async () => { + const { dom } = installSomaHarness(); + const opts = createAccordionOpts(); + + const { result, cleanup } = withEffectRoot(() => { + const provider = AccordionProvider.create(opts); + vi.spyOn(AccordionProvider.ctx, 'get').mockReturnValue(provider); + const first = AccordionItemProvider.create(itemOpts('accordion-first', 'first')); + const second = AccordionItemProvider.create(itemOpts('accordion-second', 'second')); + vi.spyOn(first, 'emitToggleEvent').mockImplementation(() => undefined); + vi.spyOn(second, 'emitToggleEvent').mockImplementation(() => undefined); + return { provider, first, second }; + }); + + expect(result.provider.props).toMatchObject({ + id: 'accordion-root', + dir: 'ltr' + }); + + await result.provider.toggleItem('first'); + expect(opts.value.current).toEqual(['first']); + expect(result.first.emitToggleEvent).toHaveBeenCalledWith('open'); + + await result.provider.toggleItem('first'); + expect(opts.value.current).toEqual(['first']); + + await result.provider.toggleItem('second'); + expect(opts.value.current).toEqual(['second']); + expect(result.first.emitToggleEvent).toHaveBeenCalledWith('close'); + expect(result.second.emitToggleEvent).toHaveBeenCalledWith('open'); + + opts.collapsible.current = true; + await result.provider.toggleItem('second'); + expect(opts.value.current).toEqual([]); + expect(result.second.emitToggleEvent).toHaveBeenCalledWith('close'); + + cleanup(); + dom.dispose(); + }); + + it('supports multiple selection mode without replacing open items', async () => { + const { dom } = installSomaHarness(); + const opts = createAccordionOpts(); + opts.type.current = 'multiple'; + + const { result: provider, cleanup } = withEffectRoot(() => AccordionProvider.create(opts)); + + await provider.toggleItem('first'); + await provider.toggleItem('second'); + expect(opts.value.current).toEqual(['first', 'second']); + + await provider.toggleItem('first'); + expect(opts.value.current).toEqual(['second']); + + cleanup(); + dom.dispose(); + }); + + it('navigates enabled triggers in root order', () => { + const { dom } = installSomaHarness(); + const focusSpy = vi.spyOn(dom, 'focus'); + const root = document.createElement('div'); + const opts = createAccordionOpts(root); + + const { result, cleanup } = withEffectRoot(() => { + const provider = AccordionProvider.create(opts); + vi.spyOn(AccordionProvider.ctx, 'get').mockReturnValue(provider); + applyAttrs(root, provider.props); + + const firstButton = document.createElement('button'); + const disabledButton = document.createElement('button'); + const lastButton = document.createElement('button'); + root.append(firstButton, disabledButton, lastButton); + + const firstItem = AccordionItemProvider.create(itemOpts('accordion-first', 'first')); + vi.spyOn(AccordionItemProvider, 'require').mockReturnValue(firstItem); + const firstTrigger = AccordionTriggerProvider.create( + partOpts('accordion-first-trigger', firstButton) + ); + applyAttrs(firstButton, firstTrigger.props); + + const disabledItem = AccordionItemProvider.create( + itemOpts('accordion-disabled', 'disabled', document.createElement('div'), true) + ); + vi.spyOn(AccordionItemProvider, 'require').mockReturnValue(disabledItem); + const disabledTrigger = AccordionTriggerProvider.create( + partOpts('accordion-disabled-trigger', disabledButton) + ); + applyAttrs(disabledButton, disabledTrigger.props); + + const lastItem = AccordionItemProvider.create(itemOpts('accordion-last', 'last')); + vi.spyOn(AccordionItemProvider, 'require').mockReturnValue(lastItem); + const lastTrigger = AccordionTriggerProvider.create( + partOpts('accordion-last-trigger', lastButton) + ); + applyAttrs(lastButton, lastTrigger.props); + + return { firstTrigger, lastTrigger, firstButton, lastButton }; + }); + + const next = keyEvent('ArrowDown', result.firstButton); + result.firstTrigger.onkeydown(next as never); + expect(next.preventDefault).toHaveBeenCalledOnce(); + expect(focusSpy).toHaveBeenCalledWith(result.lastButton); + + const end = keyEvent('End', result.firstButton); + result.firstTrigger.onkeydown(end as never); + expect(end.preventDefault).toHaveBeenCalledOnce(); + expect(focusSpy).toHaveBeenLastCalledWith(result.lastButton); + + const home = keyEvent('Home', result.lastButton); + result.lastTrigger.onkeydown(home as never); + expect(home.preventDefault).toHaveBeenCalledOnce(); + expect(focusSpy).toHaveBeenLastCalledWith(result.firstButton); + + cleanup(); + dom.dispose(); + }); + + it('wires header and content props to item state', async () => { + const { dom } = installSomaHarness(); + const opts = createAccordionOpts(); + const itemEl = document.createElement('div'); + const headerEl = document.createElement('div'); + const contentEl = document.createElement('div'); + + const { result, cleanup } = withEffectRoot(() => { + const provider = AccordionProvider.create(opts); + vi.spyOn(AccordionProvider.ctx, 'get').mockReturnValue(provider); + const item = AccordionItemProvider.create(itemOpts('accordion-first', 'first', itemEl)); + vi.spyOn(AccordionItemProvider, 'require').mockReturnValue(item); + const header = AccordionHeaderProvider.create({ + ...partOpts('accordion-first-header', headerEl), + level: state(9) + }); + const content = AccordionContentProvider.create( + partOpts('accordion-first-content', contentEl) + ); + return { provider, item, header, content }; + }); + + expect(result.header.props.id).toBe('accordion-first-header'); + expect(result.content.props).toMatchObject({ + id: 'accordion-first-content', + hidden: true, + style: { + '--soma-accordion-content-height': '0px', + '--soma-accordion-content-width': '0px' + } + }); + + result.item.setContentRef(contentEl); + result.content.item.contentHeight.current = 42; + result.content.item.contentWidth.current = 240; + await result.provider.toggleItem('first'); + await tick(); + + expect(result.content.isHidden).toBe(false); + expect(result.content.props.hidden).toBeUndefined(); + expect(result.content.props.style).toMatchObject({ + '--soma-accordion-content-height': '42px', + '--soma-accordion-content-width': '240px' + }); + + cleanup(); + dom.dispose(); + }); +});