diff --git a/continue.md b/continue.md index ba9a9c4a6..aaa5a2f3b 100644 --- a/continue.md +++ b/continue.md @@ -49,9 +49,13 @@ Actualizacion 2026-05-15: `scrollOffset + delta` como fuente reactiva. - Cobertura nueva para VirtualGrid: cálculo de ventana 2D y `scrollToCell` via `ActiveDom`. + - Cobertura nueva para NumberField: parsing localizable, teclado spinbutton, + triggers, props ARIA y scrubber. + - Correccion NumberField: el root expone `dir` efectivo (`prop -> prefs`) en + lugar del prop crudo. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - - `npm run test` -> 186 archivos, 2085 tests OK. + - `npm run test` -> 187 archivos, 2089 tests OK. - tests focales de Select/Popover/Toast/RangeCalendar -> 11 tests OK. - tests focales Dialog/Drawer/Popover/Select -> 10 tests OK. - `command-provider.svelte.test.ts` -> 2 tests OK. @@ -66,6 +70,7 @@ Actualizacion 2026-05-15: - `date-field-provider.svelte.test.ts` -> 7 tests OK. - `virtual-list-provider.svelte.test.ts` -> 3 tests OK. - `virtual-grid-provider.svelte.test.ts` -> 2 tests OK. + - `number-field-provider.svelte.test.ts` -> 4 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index fe9eece4b..50f3d61db 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -482,11 +482,13 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A `scrollToIndex` y compensación anti-jump via `ActiveDom`. - `virtual-grid/virtual-grid-provider.svelte.test.ts` — cálculo de ventana 2D y `scrollToCell` via `ActiveDom`. +- `number-field/number-field-provider.svelte.test.ts` — parsing localizable, + teclado spinbutton, triggers, props ARIA y scrubber. Pendiente: seguir ampliando cobertura por familias de alto riesgo fuera del -bloque fecha/hora y virtualización. `table-core`, `form-core` y el scorer de -Command ya no viven dentro de Soma: se consumen desde `$libs/datagrid`, -`$libs/forms` y `$libs/strings`. +bloque fecha/hora, virtualización e inputs numericos. `table-core`, +`form-core` y el scorer de Command ya no viven dentro de Soma: se consumen +desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. ### Convencion diff --git a/src/uix/soma/components/number-field/number-field-provider.svelte.test.ts b/src/uix/soma/components/number-field/number-field-provider.svelte.test.ts new file mode 100644 index 000000000..3ee12dd1a --- /dev/null +++ b/src/uix/soma/components/number-field/number-field-provider.svelte.test.ts @@ -0,0 +1,240 @@ +// @vitest-environment jsdom + +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; +import { FieldProvider } from '../field/field-provider.svelte'; + +import { + NumberFieldDecrementTriggerProvider, + NumberFieldIncrementTriggerProvider, + NumberFieldInputProvider, + NumberFieldProvider, + NumberFieldScrubberProvider +} from './number-field-provider.svelte'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness() { + const dom = createActiveDom(); + const soma = { + dom, + langs: { + getLocale: () => 'de-DE', + ts: (key: string) => key + }, + prefs: { + getDir: () => 'rtl' + }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(FieldProvider, 'get').mockReturnValue(undefined); + vi.spyOn(NumberFieldProvider.ctx, 'set').mockImplementation((value) => value); + + return { dom }; +} + +function createNumberFieldOpts() { + return { + id: state('number-field-root'), + ref: state(null), + value: state(undefined), + min: state(undefined), + max: state(undefined), + step: state(1), + largeStep: state(undefined), + locale: state(undefined), + dir: state<'ltr' | 'rtl' | undefined>(undefined), + formatOptions: state(undefined), + clampOnBlur: state(true), + allowMouseWheel: state(false), + disabled: state(false), + readonly: state(false), + required: state(false), + invalid: state(false), + name: state(undefined), + onValueCommit: state<((value: number) => void) | undefined>(undefined) + }; +} + +describe('NumberFieldProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('parses locale edit text, rounds by step and clamps on blur', () => { + const { dom } = installSomaHarness(); + const opts = createNumberFieldOpts(); + const onCommit = vi.fn(); + opts.min.current = 0; + opts.max.current = 2; + opts.step.current = 0.25; + opts.value.current = 1; + opts.onValueCommit.current = onCommit; + + const { result: provider, cleanup } = withEffectRoot(() => NumberFieldProvider.create(opts)); + + provider.handleFocus({} as never); + expect(provider.inputValue).toBe('1'); + + const input = document.createElement('input'); + input.value = '2,9'; + provider.handleInput({ currentTarget: input } as never); + provider.handleBlur({} as never); + + expect(opts.value.current).toBe(2); + expect(onCommit).toHaveBeenCalledWith(2); + expect(provider.inputValue).toBe('2'); + + cleanup(); + dom.dispose(); + }); + + it('maps keyboard commands and trigger clicks to bounded value changes', () => { + const { dom } = installSomaHarness(); + const opts = createNumberFieldOpts(); + opts.min.current = 0; + opts.max.current = 10; + opts.step.current = 0.5; + opts.largeStep.current = 4; + opts.value.current = 1; + + const { result: provider, cleanup } = withEffectRoot(() => NumberFieldProvider.create(opts)); + vi.spyOn(NumberFieldProvider.ctx, 'get').mockReturnValue(provider); + + const preventDefault = vi.fn(); + provider.handleKeydown({ + key: 'ArrowUp', + shiftKey: true, + preventDefault + } as never); + expect(opts.value.current).toBe(5); + expect(preventDefault).toHaveBeenCalledOnce(); + + provider.handleKeydown({ + key: 'End', + shiftKey: false, + preventDefault + } as never); + expect(opts.value.current).toBe(10); + + const increment = NumberFieldIncrementTriggerProvider.create({ + id: state('number-field-increment'), + ref: state(null) + }); + expect(increment.isDisabled).toBe(true); + + const decrement = NumberFieldDecrementTriggerProvider.create({ + id: state('number-field-decrement'), + ref: state(null) + }); + decrement.handleClick(); + expect(opts.value.current).toBe(9.5); + + cleanup(); + dom.dispose(); + }); + + it('exposes spinbutton props with resolved locale direction and field state', () => { + const { dom } = installSomaHarness(); + const opts = createNumberFieldOpts(); + opts.value.current = 3; + opts.min.current = 0; + opts.max.current = 5; + opts.required.current = true; + opts.invalid.current = true; + opts.name.current = 'amount'; + + const { result: provider, cleanup } = withEffectRoot(() => NumberFieldProvider.create(opts)); + vi.spyOn(NumberFieldProvider.ctx, 'get').mockReturnValue(provider); + + const input = NumberFieldInputProvider.create({ + id: state('number-field-input'), + ref: state(null) + }); + + expect(provider.dir).toBe('rtl'); + expect(provider.props.dir).toBe('rtl'); + expect(input.props).toMatchObject({ + role: 'spinbutton', + inputmode: 'decimal', + dir: 'rtl', + value: '3', + 'aria-valuenow': 3, + 'aria-valuemin': 0, + 'aria-valuemax': 5, + 'aria-valuetext': '3', + 'aria-required': 'true', + 'aria-invalid': 'true', + name: 'amount' + }); + + cleanup(); + dom.dispose(); + }); + + it('scrubs after the movement buffer and commits the final value once', () => { + const { dom } = installSomaHarness(); + const opts = createNumberFieldOpts(); + const onCommit = vi.fn(); + opts.value.current = 10; + opts.step.current = 2; + opts.onValueCommit.current = onCommit; + + const { result: provider, cleanup } = withEffectRoot(() => NumberFieldProvider.create(opts)); + vi.spyOn(NumberFieldProvider.ctx, 'get').mockReturnValue(provider); + + const scrubber = NumberFieldScrubberProvider.create({ + id: state('number-field-scrubber'), + ref: state(null), + direction: state<'horizontal' | 'vertical'>('horizontal'), + sensitivity: state(5) + }); + const target = { setPointerCapture: vi.fn() }; + + scrubber.onpointerdown({ + button: 0, + clientX: 0, + clientY: 0, + preventDefault: vi.fn() + } as never); + scrubber.onpointermove({ + clientX: 15, + clientY: 0, + pointerId: 1, + currentTarget: target, + preventDefault: vi.fn() + } as never); + + expect(provider.scrubbing).toBe(true); + expect(target.setPointerCapture).toHaveBeenCalledWith(1); + expect(opts.value.current).toBe(16); + + scrubber.onpointerup(); + + expect(provider.scrubbing).toBe(false); + expect(onCommit).toHaveBeenCalledOnce(); + expect(onCommit).toHaveBeenCalledWith(16); + + cleanup(); + dom.dispose(); + }); +}); diff --git a/src/uix/soma/components/number-field/number-field-provider.svelte.ts b/src/uix/soma/components/number-field/number-field-provider.svelte.ts index eb329570f..517a5605c 100644 --- a/src/uix/soma/components/number-field/number-field-provider.svelte.ts +++ b/src/uix/soma/components/number-field/number-field-provider.svelte.ts @@ -434,7 +434,7 @@ export class NumberFieldProvider { readonly props = $derived.by(() => this.runtimePart.assert({ ...this.runtimePart.props, - dir: this.opts.dir.current + dir: this.dir } as const) ); }