diff --git a/continue.md b/continue.md index 054a8e6bb..082e4ca10 100644 --- a/continue.md +++ b/continue.md @@ -27,9 +27,11 @@ Actualizacion 2026-05-15: - Cobertura nueva para DatePicker, DateRangePicker y TimePicker: registro runtime, cierre controlado tras selección y escritura de sliders de hora al valor compartido. + - Cobertura nueva para TimeRangePicker: valores por endpoint, sliders y cierre + al completar ambos extremos. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - - `npm run test` -> 180 archivos, 2065 tests OK. + - `npm run test` -> 181 archivos, 2068 tests OK. - tests focales de Select/Popover/Toast/RangeCalendar -> 11 tests OK. - tests focales Dialog/Drawer/Popover/Select -> 10 tests OK. - `command-provider.svelte.test.ts` -> 2 tests OK. @@ -37,6 +39,7 @@ Actualizacion 2026-05-15: - `$libs/forms/form-core.svelte.test.ts` -> 3 tests OK. - `combobox-provider.svelte.test.ts` -> 3 tests OK. - tests focales DatePicker/DateRangePicker/TimePicker -> 7 tests OK. + - `time-range-picker-provider.svelte.test.ts` -> 3 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index 60401cffa..1cd565f43 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -469,11 +469,12 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A runtime y cierre controlado por `closeOnRangeSelect`. - `time-picker/time-picker-provider.svelte.test.ts` — registro runtime, valores de placeholder y escritura de sliders al valor compartido. +- `time-range-picker/time-range-picker-provider.svelte.test.ts` — valores por + endpoint, escritura de sliders y cierre al completar rango. -Pendiente: ampliar cobertura al `TimeRangePicker` y a los providers internos de -fecha/hora de mayor tamano. `table-core`, `form-core` y el scorer de Command ya -no viven dentro de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y -`$libs/strings`. +Pendiente: ampliar cobertura a los providers internos de fecha/hora de mayor +tamano. `table-core`, `form-core` y el scorer de Command ya no viven dentro de +Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. ### Convencion diff --git a/src/uix/soma/components/time-range-picker/time-range-picker-provider.svelte.test.ts b/src/uix/soma/components/time-range-picker/time-range-picker-provider.svelte.test.ts new file mode 100644 index 000000000..69d6e7596 --- /dev/null +++ b/src/uix/soma/components/time-range-picker/time-range-picker-provider.svelte.test.ts @@ -0,0 +1,170 @@ +// @vitest-environment jsdom + +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { Time } from '$libs/days'; +import type { + EditableTimeSegmentPart, + HourCycle, + TimeGranularity, + TimeOnInvalid, + TimeRange, + TimeRangeValidator, + TimeValue +} from '$libs/days'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; +import type { Direction, OnChangeFn } from '../../types'; + +import { TimeRangePickerProvider } from './time-range-picker-provider.svelte'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness(hourCycle?: HourCycle) { + const dom = createActiveDom(); + const soma = { + dom, + langs: { + getLocale: () => 'en-US', + ts: (key: string) => key + }, + dates: { + getHourCycle: () => hourCycle + }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(TimeRangePickerProvider.ctx, 'set').mockImplementation((value) => value); + + return { dom }; +} + +function createTimeRangePickerOpts() { + return { + id: state('time-range-picker-root'), + ref: state(null), + value: state({ start: undefined, end: undefined }), + placeholder: state(new Time(13, 45, 30)), + startValue: state(undefined), + endValue: state(undefined), + open: state(true), + validate: state(undefined), + onInvalid: state(undefined), + minValue: state(undefined), + maxValue: state(undefined), + disabled: state(false), + readonly: state(false), + startReadonlySegments: state([]), + endReadonlySegments: state(['dayPeriod']), + required: state(false), + closeOnRangeComplete: state(true), + granularity: state(undefined), + hideTimeZone: state(false), + hourCycle: state(undefined), + locale: state('en-US'), + dir: state('ltr'), + hourStep: state(1), + minuteStep: state(1), + secondStep: state(1), + errorMessageId: state(undefined), + onOpenChangeComplete: state>(() => {}) + }; +} + +describe('TimeRangePickerProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('registers the provider part and exposes placeholder values per endpoint', () => { + const { dom } = installSomaHarness(24); + const opts = createTimeRangePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => + TimeRangePickerProvider.create(opts) + ); + + expect(provider.runtimePart.props.id).toBe('time-range-picker-root'); + expect(provider.inferredGranularity).toBe('minute'); + expect(provider.getHour('start')).toBe(13); + expect(provider.getMinute('end')).toBe(45); + expect(provider.getSecond('start')).toBe(30); + expect(provider.getDayPeriod('end')).toBe('PM'); + expect(provider.getReadonlySegments('start')).toEqual([]); + expect(provider.getReadonlySegments('end')).toEqual(['dayPeriod']); + + cleanup(); + dom.dispose(); + }); + + it('writes slider changes to the selected endpoint only', () => { + const { dom } = installSomaHarness(24); + const opts = createTimeRangePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => + TimeRangePickerProvider.create(opts) + ); + + provider.setHour('start', 9); + provider.setMinute('start', 5); + provider.setSecond('end', 10); + + expect(opts.startValue.current?.hour).toBe(9); + expect(opts.startValue.current?.minute).toBe(5); + expect(opts.startValue.current?.second).toBe(30); + expect(opts.endValue.current?.hour).toBe(13); + expect(opts.endValue.current?.minute).toBe(45); + expect(opts.endValue.current?.second).toBe(10); + + cleanup(); + dom.dispose(); + }); + + it('maps 12-hour input and closes only after both endpoints exist', () => { + const { dom } = installSomaHarness(12); + const opts = createTimeRangePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => + TimeRangePickerProvider.create(opts) + ); + + expect(provider.getHour('start')).toBe(1); + provider.setHour('start', 3); + expect(opts.startValue.current?.hour).toBe(15); + + provider.handleSelect(); + expect(opts.open.current).toBe(true); + + provider.setDayPeriod('start', 'AM'); + provider.setHour('end', 4); + expect(opts.startValue.current?.hour).toBe(3); + expect(opts.endValue.current?.hour).toBe(16); + + provider.handleSelect(); + expect(opts.open.current).toBe(false); + + opts.open.current = true; + opts.closeOnRangeComplete.current = false; + provider.handleSelect(); + expect(opts.open.current).toBe(true); + + cleanup(); + dom.dispose(); + }); +});