diff --git a/continue.md b/continue.md index 22d335ec8..054a8e6bb 100644 --- a/continue.md +++ b/continue.md @@ -24,15 +24,19 @@ Actualizacion 2026-05-15: disponible, con fallback nativo solo para uso standalone fuera de UIX. - Cobertura nueva para Combobox: selección single/multiple, `inputValue` y filtrado de items disabled. + - Cobertura nueva para DatePicker, DateRangePicker y TimePicker: registro + runtime, cierre controlado tras selección y escritura de sliders de hora al + valor compartido. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - - `npm run test` -> 177 archivos, 2058 tests OK. + - `npm run test` -> 180 archivos, 2065 tests OK. - tests focales de Select/Popover/Toast/RangeCalendar -> 11 tests OK. - tests focales Dialog/Drawer/Popover/Select -> 10 tests OK. - `command-provider.svelte.test.ts` -> 2 tests OK. - `$libs/datagrid/table-core.svelte.test.ts` -> 8 tests OK. - `$libs/forms/form-core.svelte.test.ts` -> 3 tests OK. - `combobox-provider.svelte.test.ts` -> 3 tests OK. + - tests focales DatePicker/DateRangePicker/TimePicker -> 7 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index 418afdf8f..60401cffa 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -463,10 +463,17 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A orden de endpoints y limites min/max. - `date-field/date-field-provider.svelte.test.ts` — helpers UI de segmentos, lectura DOM y navegación por `ActiveDom`. - -Pendiente: ampliar cobertura a DatePicker y los pickers/ranges de fecha/hora -restantes. `table-core`, `form-core` y el scorer de Command ya no viven dentro -de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. +- `date-picker/date-picker-provider.svelte.test.ts` — registro runtime y + cierre controlado por `closeOnDateSelect`. +- `date-range-picker/date-range-picker-provider.svelte.test.ts` — registro + runtime y cierre controlado por `closeOnRangeSelect`. +- `time-picker/time-picker-provider.svelte.test.ts` — registro runtime, + valores de placeholder y escritura de sliders al valor compartido. + +Pendiente: ampliar cobertura al `TimeRangePicker` y a los providers internos de +fecha/hora de mayor tamano. `table-core`, `form-core` y el scorer de Command ya +no viven dentro de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y +`$libs/strings`. ### Convencion diff --git a/src/uix/soma/components/date-picker/date-picker-provider.svelte.test.ts b/src/uix/soma/components/date-picker/date-picker-provider.svelte.test.ts new file mode 100644 index 000000000..0085064b1 --- /dev/null +++ b/src/uix/soma/components/date-picker/date-picker-provider.svelte.test.ts @@ -0,0 +1,135 @@ +// @vitest-environment jsdom + +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { CalendarDate } from '$libs/days'; +import type { + DateMatcher, + DateOnInvalid, + DateValidator, + DateValue, + EditableSegmentPart, + Granularity, + HourCycle, + WeekStartsOn +} from '$libs/days'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; +import type { Direction, OnChangeFn } from '../../types'; + +import { DatePickerProvider } from './date-picker-provider.svelte'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness() { + const dom = createActiveDom(); + const soma = { + dom, + langs: { + getLocale: () => 'en-US', + ts: (key: string) => key + }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(DatePickerProvider.ctx, 'set').mockImplementation((value) => value); + + return { dom }; +} + +function createDatePickerOpts() { + const placeholder = new CalendarDate(2026, 5, 15); + + return { + id: state('date-picker-root'), + ref: state(null), + value: state(undefined), + placeholder: state(placeholder), + open: state(true), + validate: state(undefined), + onInvalid: state(undefined), + minValue: state(undefined), + maxValue: state(undefined), + isDateDisabled: state(undefined), + isDateUnavailable: state(undefined), + disabled: state(false), + readonly: state(false), + readonlySegments: state([]), + required: state(false), + closeOnDateSelect: state(true), + granularity: state(undefined), + hideTimeZone: state(false), + hourCycle: state(undefined), + locale: state('en-US'), + dir: state('ltr'), + pagedNavigation: state(false), + weekStartsOn: state(undefined), + weekdayFormat: state('narrow'), + fixedWeeks: state(false), + numberOfMonths: state(1), + calendarLabel: state(undefined), + disableDaysOutsideMonth: state(false), + preventDeselect: state(false), + initialFocus: state(false), + monthFormat: state string)>('long'), + yearFormat: state string)>('numeric'), + showWeekNumbers: state(false), + weekNumberFormat: state<'iso' | 'simple'>('iso'), + isDateHoliday: state(undefined), + announceNavigation: state(true), + errorMessageId: state(undefined), + onOpenChangeComplete: state>(() => {}) + }; +} + +describe('DatePickerProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('registers the provider part through SomaRuntime', () => { + const { dom } = installSomaHarness(); + const opts = createDatePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => DatePickerProvider.create(opts)); + + expect(provider.runtimePart.props.id).toBe('date-picker-root'); + + cleanup(); + dom.dispose(); + }); + + it('closes the popover only when closeOnDateSelect is enabled', () => { + const { dom } = installSomaHarness(); + const opts = createDatePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => DatePickerProvider.create(opts)); + + provider.handleDateSelect(); + expect(opts.open.current).toBe(false); + + opts.open.current = true; + opts.closeOnDateSelect.current = false; + provider.handleDateSelect(); + expect(opts.open.current).toBe(true); + + cleanup(); + dom.dispose(); + }); +}); diff --git a/src/uix/soma/components/date-range-picker/date-range-picker-provider.svelte.test.ts b/src/uix/soma/components/date-range-picker/date-range-picker-provider.svelte.test.ts new file mode 100644 index 000000000..97c5e63f4 --- /dev/null +++ b/src/uix/soma/components/date-range-picker/date-range-picker-provider.svelte.test.ts @@ -0,0 +1,146 @@ +// @vitest-environment jsdom + +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { CalendarDate } from '$libs/days'; +import type { + DateMatcher, + DateOnInvalid, + DateRange, + DateRangeValidator, + DateValue, + EditableSegmentPart, + Granularity, + HourCycle, + WeekStartsOn +} from '$libs/days'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; +import type { Direction, OnChangeFn } from '../../types'; + +import { DateRangePickerProvider } from './date-range-picker-provider.svelte'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness() { + const dom = createActiveDom(); + const soma = { + dom, + langs: { + getLocale: () => 'en-US', + ts: (key: string) => key + }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(DateRangePickerProvider.ctx, 'set').mockImplementation((value) => value); + + return { dom }; +} + +function createDateRangePickerOpts() { + const placeholder = new CalendarDate(2026, 5, 15); + + return { + id: state('date-range-picker-root'), + ref: state(null), + value: state({ start: undefined, end: undefined }), + placeholder: state(placeholder), + startValue: state(undefined), + endValue: state(undefined), + open: state(true), + validate: state(undefined), + onInvalid: state(undefined), + minValue: state(undefined), + maxValue: state(undefined), + minDays: state(undefined), + maxDays: state(undefined), + allowSingleDay: state(true), + isDateDisabled: state(undefined), + isDateUnavailable: state(undefined), + isDateHoliday: state(undefined), + disabled: state(false), + readonly: state(false), + startReadonlySegments: state([]), + endReadonlySegments: state([]), + required: state(false), + closeOnRangeSelect: state(true), + granularity: state(undefined), + hideTimeZone: state(false), + hourCycle: state(undefined), + locale: state('en-US'), + dir: state('ltr'), + pagedNavigation: state(false), + weekStartsOn: state(undefined), + weekdayFormat: state('narrow'), + fixedWeeks: state(false), + numberOfMonths: state(1), + calendarLabel: state(undefined), + disableDaysOutsideMonth: state(false), + preventDeselect: state(false), + initialFocus: state(false), + monthFormat: state string)>('long'), + yearFormat: state string)>('numeric'), + showWeekNumbers: state(false), + weekNumberFormat: state<'iso' | 'simple'>('iso'), + announceNavigation: state(true), + errorMessageId: state(undefined), + onOpenChangeComplete: state>(() => {}) + }; +} + +describe('DateRangePickerProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('registers the provider part through SomaRuntime', () => { + const { dom } = installSomaHarness(); + const opts = createDateRangePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => + DateRangePickerProvider.create(opts) + ); + + expect(provider.runtimePart.props.id).toBe('date-range-picker-root'); + + cleanup(); + dom.dispose(); + }); + + it('closes the popover only when closeOnRangeSelect is enabled', () => { + const { dom } = installSomaHarness(); + const opts = createDateRangePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => + DateRangePickerProvider.create(opts) + ); + + provider.handleRangeSelect(); + expect(opts.open.current).toBe(false); + + opts.open.current = true; + opts.closeOnRangeSelect.current = false; + provider.handleRangeSelect(); + expect(opts.open.current).toBe(true); + + cleanup(); + dom.dispose(); + }); +}); diff --git a/src/uix/soma/components/time-picker/time-picker-provider.svelte.test.ts b/src/uix/soma/components/time-picker/time-picker-provider.svelte.test.ts new file mode 100644 index 000000000..115273339 --- /dev/null +++ b/src/uix/soma/components/time-picker/time-picker-provider.svelte.test.ts @@ -0,0 +1,150 @@ +// @vitest-environment jsdom + +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { Time } from '$libs/days'; +import type { + EditableTimeSegmentPart, + HourCycle, + TimeGranularity, + TimeOnInvalid, + TimeValidator, + TimeValue +} from '$libs/days'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; +import type { Direction, OnChangeFn } from '../../types'; + +import { TimePickerProvider } from './time-picker-provider.svelte'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness(hourCycle?: HourCycle) { + const dom = createActiveDom(); + const soma = { + dom, + langs: { + getLocale: () => 'en-US', + ts: (key: string) => key + }, + dates: { + getHourCycle: () => hourCycle + }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(TimePickerProvider.ctx, 'set').mockImplementation((value) => value); + + return { dom }; +} + +function createTimePickerOpts() { + return { + id: state('time-picker-root'), + ref: state(null), + value: state(undefined), + placeholder: state(new Time(13, 45, 30)), + open: state(true), + validate: state | undefined>(undefined), + onInvalid: state(undefined), + minValue: state(undefined), + maxValue: state(undefined), + disabled: state(false), + readonly: state(false), + readonlySegments: state([]), + required: state(false), + granularity: state(undefined), + hideTimeZone: state(false), + hourCycle: state(undefined), + locale: state('en-US'), + dir: state('ltr'), + hourStep: state(1), + minuteStep: state(1), + secondStep: state(1), + errorMessageId: state(undefined), + onOpenChangeComplete: state>(() => {}) + }; +} + +describe('TimePickerProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('registers the provider part and exposes 24-hour placeholder values', () => { + const { dom } = installSomaHarness(24); + const opts = createTimePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => TimePickerProvider.create(opts)); + + expect(provider.runtimePart.props.id).toBe('time-picker-root'); + expect(provider.inferredGranularity).toBe('minute'); + expect(provider.hour).toBe(13); + expect(provider.minute).toBe(45); + expect(provider.second).toBe(30); + expect(provider.dayPeriod).toBe('PM'); + expect(provider.hourMin).toBe(0); + expect(provider.hourMax).toBe(23); + + cleanup(); + dom.dispose(); + }); + + it('writes slider changes back to the shared value source', () => { + const { dom } = installSomaHarness(24); + const opts = createTimePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => TimePickerProvider.create(opts)); + + provider.setHour(9); + provider.setMinute(5); + provider.setSecond(10); + + expect(opts.value.current?.hour).toBe(9); + expect(opts.value.current?.minute).toBe(5); + expect(opts.value.current?.second).toBe(10); + + cleanup(); + dom.dispose(); + }); + + it('maps 12-hour input through the active day period', () => { + const { dom } = installSomaHarness(12); + const opts = createTimePickerOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => TimePickerProvider.create(opts)); + + expect(provider.hour).toBe(1); + expect(provider.dayPeriod).toBe('PM'); + expect(provider.hourMin).toBe(1); + expect(provider.hourMax).toBe(12); + + provider.setHour(3); + expect(opts.value.current?.hour).toBe(15); + + provider.setDayPeriod('AM'); + expect(opts.value.current?.hour).toBe(3); + + provider.setDayPeriod('PM'); + expect(opts.value.current?.hour).toBe(15); + + cleanup(); + dom.dispose(); + }); +});