From 89790957a07e3c6da58b4ff0973faa19ac725241 Mon Sep 17 00:00:00 2001 From: dev Date: Fri, 15 May 2026 23:42:09 +0200 Subject: [PATCH] Add listbox provider coverage --- continue.md | 5 +- src/uix/soma/SOMA_ARCHITECTURE.md | 8 +- .../listbox/listbox-provider.svelte.test.ts | 293 ++++++++++++++++++ 3 files changed, 302 insertions(+), 4 deletions(-) create mode 100644 src/uix/soma/components/listbox/listbox-provider.svelte.test.ts diff --git a/continue.md b/continue.md index ab3c7836e..d0a12f416 100644 --- a/continue.md +++ b/continue.md @@ -70,9 +70,11 @@ Actualizacion 2026-05-15: y group/separator. - Cobertura nueva para Menubar: coordinación de menús hermanos, hover-follow, navegación horizontal entre triggers y cambio de menú desde content. + - Cobertura nueva para Listbox: props ARIA root, selección, navegación, + typeahead, indicador de item y grupos. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - - `npm run test` -> 195 archivos, 2125 tests OK. + - `npm run test` -> 196 archivos, 2129 tests OK. - tests focales de Select/Popover/Toast/RangeCalendar -> 11 tests OK. - tests focales Dialog/Drawer/Popover/Select -> 10 tests OK. - `command-provider.svelte.test.ts` -> 2 tests OK. @@ -96,6 +98,7 @@ Actualizacion 2026-05-15: - `dropdown-menu-provider.svelte.test.ts` -> 6 tests OK. - `context-menu-provider.svelte.test.ts` -> 6 tests OK. - `menubar-provider.svelte.test.ts` -> 4 tests OK. + - `listbox-provider.svelte.test.ts` -> 4 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index 3531fb4ad..223e3caf2 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -502,12 +502,14 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A submenu y group/separator. - `menubar/menubar-provider.svelte.test.ts` — coordinación de menús hermanos, hover-follow, navegación horizontal y cambio de menú desde content. +- `listbox/listbox-provider.svelte.test.ts` — props ARIA root, selección, + navegación, typeahead, indicador de item y grupos. Pendiente: seguir ampliando cobertura por familias de alto riesgo fuera del bloque fecha/hora, virtualización, inputs numericos, file upload, color y -navegacion superior/treegrid/dropdown/context-menu/menubar. `table-core`, -`form-core` y el scorer de Command ya no viven dentro de Soma: se consumen -desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. +navegacion superior/treegrid/dropdown/context-menu/menubar/listbox. +`table-core`, `form-core` y el scorer de Command ya no viven dentro de Soma: +se consumen desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. ### Convencion diff --git a/src/uix/soma/components/listbox/listbox-provider.svelte.test.ts b/src/uix/soma/components/listbox/listbox-provider.svelte.test.ts new file mode 100644 index 000000000..291bb693e --- /dev/null +++ b/src/uix/soma/components/listbox/listbox-provider.svelte.test.ts @@ -0,0 +1,293 @@ +// @vitest-environment jsdom + +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; +import { FieldProvider } from '../field/field-provider.svelte'; + +import { + ListboxGroupLabelProvider, + ListboxGroupProvider, + ListboxItemIndicatorProvider, + ListboxItemProvider, + ListboxProvider +} from './listbox-provider.svelte'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness() { + const dom = createActiveDom(); + const timers = { + schedule: vi.fn((key: string, delay: number, callback: () => void) => { + const timer = { key, delay, callback, cancel: vi.fn() }; + return timer; + }) + }; + const soma = { + dom, + prefs: { getDir: () => 'ltr' }, + langs: { ts: vi.fn(() => 'Options') }, + uix: { timers }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(FieldProvider, 'get').mockReturnValue(undefined); + vi.spyOn(ListboxProvider.ctx, 'set').mockImplementation((value) => value); + vi.spyOn(ListboxItemProvider.ctx, 'set').mockImplementation((value) => value); + vi.spyOn(ListboxGroupProvider.ctx, 'set').mockImplementation((value) => value); + + return { dom }; +} + +function createRoot() { + const root = document.createElement('div'); + root.setAttribute('data-listbox', ''); + document.body.appendChild(root); + return root; +} + +function createItemEl(value: string, text: string, disabled = false) { + const item = document.createElement('div'); + item.setAttribute('data-listbox-item', ''); + item.setAttribute('data-value', value); + item.setAttribute('data-text-value', text); + item.textContent = text; + if (disabled) item.setAttribute('data-disabled', ''); + return item; +} + +function createListboxOpts(root = createRoot()) { + return { + id: state('listbox-root'), + ref: state(root), + value: state([]), + selectionMode: state<'single' | 'multiple'>('single'), + loop: state(true), + typeahead: state(true), + typeaheadTimeout: state(500), + orientation: state<'horizontal' | 'vertical'>('vertical'), + dir: state<'ltr' | 'rtl' | undefined>(undefined), + disabled: state(false), + readonly: state(false), + required: state(false), + invalid: state(false), + name: state(undefined), + ariaLabel: state(undefined), + ariaLabelledby: state(undefined), + onValueChange: state<((value: string[]) => void) | undefined>(undefined) + }; +} + +function itemOpts(id: string, value: string, el: HTMLElement, disabled = false) { + return { + id: state(id), + ref: state(el), + value: state(value), + disabled: state(disabled), + textValue: state(el.getAttribute('data-text-value') ?? undefined) + }; +} + +function keyEvent(key: string, currentTarget: HTMLElement, init: Partial = {}) { + return { + key, + currentTarget, + ctrlKey: false, + metaKey: false, + altKey: false, + preventDefault: vi.fn(), + ...init + }; +} + +function clickEvent(currentTarget: HTMLElement) { + return { + currentTarget + }; +} + +describe('ListboxProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('exposes root accessibility props and focus state', () => { + const { dom } = installSomaHarness(); + const opts = createListboxOpts(); + opts.selectionMode.current = 'multiple'; + opts.required.current = true; + + const { result: provider, cleanup } = withEffectRoot(() => ListboxProvider.create(opts)); + + expect(provider.props).toMatchObject({ + role: 'listbox', + dir: 'ltr', + 'aria-orientation': 'vertical', + 'aria-multiselectable': true, + 'aria-required': true, + 'aria-label': 'Options', + 'data-orientation': 'vertical', + 'data-required': '', + 'data-empty': '' + }); + + provider.onfocus(); + expect(provider.snippetProps).toMatchObject({ + value: [], + isEmpty: true, + isFocused: true + }); + expect(provider.props['data-focused']).toBe(''); + + cleanup(); + dom.dispose(); + }); + + it('selects and toggles items while focusing through ActiveDom', () => { + const { dom } = installSomaHarness(); + const focusSpy = vi.spyOn(dom, 'focus'); + const root = createRoot(); + const alphaEl = createItemEl('alpha', 'Alpha'); + const betaEl = createItemEl('beta', 'Beta'); + root.append(alphaEl, betaEl); + const opts = createListboxOpts(root); + opts.selectionMode.current = 'multiple'; + const onValueChange = vi.fn(); + opts.onValueChange.current = onValueChange; + + const { result, cleanup } = withEffectRoot(() => { + const provider = ListboxProvider.create(opts); + vi.spyOn(ListboxProvider.ctx, 'get').mockReturnValue(provider); + const alpha = ListboxItemProvider.create(itemOpts('listbox-alpha', 'alpha', alphaEl)); + const beta = ListboxItemProvider.create(itemOpts('listbox-beta', 'beta', betaEl)); + return { provider, alpha, beta }; + }); + + expect(result.alpha.props).toMatchObject({ + role: 'option', + tabindex: 0, + 'aria-selected': false, + 'data-state': 'unselected', + 'data-value': 'alpha' + }); + + result.alpha.onclick(clickEvent(alphaEl) as never); + expect(opts.value.current).toEqual(['alpha']); + expect(onValueChange).toHaveBeenCalledWith(['alpha']); + expect(focusSpy).toHaveBeenCalledWith(alphaEl); + expect(result.alpha.props['data-state']).toBe('selected'); + expect(result.beta.props.tabindex).toBe(-1); + + result.alpha.onclick(clickEvent(alphaEl) as never); + expect(opts.value.current).toEqual([]); + expect(onValueChange).toHaveBeenLastCalledWith([]); + + cleanup(); + dom.dispose(); + }); + + it('navigates enabled items and supports typeahead', () => { + const { dom } = installSomaHarness(); + const focusSpy = vi.spyOn(dom, 'focus'); + const root = createRoot(); + const alphaEl = createItemEl('alpha', 'Alpha'); + const betaEl = createItemEl('beta', 'Beta'); + const gammaEl = createItemEl('gamma', 'Gamma'); + root.append(alphaEl, betaEl, gammaEl); + const opts = createListboxOpts(root); + opts.selectionMode.current = 'multiple'; + + const { result, cleanup } = withEffectRoot(() => { + const provider = ListboxProvider.create(opts); + vi.spyOn(ListboxProvider.ctx, 'get').mockReturnValue(provider); + const alpha = ListboxItemProvider.create(itemOpts('listbox-alpha', 'alpha', alphaEl)); + return { alpha }; + }); + + const next = keyEvent('ArrowDown', alphaEl); + result.alpha.onkeydown(next as never); + expect(next.preventDefault).toHaveBeenCalledOnce(); + expect(focusSpy).toHaveBeenCalledWith(betaEl); + + const end = keyEvent('End', alphaEl); + result.alpha.onkeydown(end as never); + expect(end.preventDefault).toHaveBeenCalledOnce(); + expect(focusSpy).toHaveBeenLastCalledWith(gammaEl); + + const selectAll = keyEvent('A', alphaEl, { ctrlKey: true }); + result.alpha.onkeydown(selectAll as never); + expect(selectAll.preventDefault).toHaveBeenCalledOnce(); + expect(opts.value.current).toEqual(['alpha', 'beta', 'gamma']); + + result.alpha.onkeydown(keyEvent('g', alphaEl) as never); + expect(focusSpy).toHaveBeenLastCalledWith(gammaEl); + + cleanup(); + dom.dispose(); + }); + + it('wires item indicators and group labels to their parent contexts', () => { + const { dom } = installSomaHarness(); + const root = createRoot(); + const alphaEl = createItemEl('alpha', 'Alpha'); + root.append(alphaEl); + const opts = createListboxOpts(root); + opts.value.current = ['alpha']; + + const { result, cleanup } = withEffectRoot(() => { + const provider = ListboxProvider.create(opts); + vi.spyOn(ListboxProvider.ctx, 'get').mockReturnValue(provider); + const item = ListboxItemProvider.create(itemOpts('listbox-alpha', 'alpha', alphaEl)); + vi.spyOn(ListboxItemProvider, 'require').mockReturnValue(item); + const indicator = ListboxItemIndicatorProvider.create({ + id: state('listbox-alpha-indicator'), + ref: state(document.createElement('span')) + }); + const group = ListboxGroupProvider.create({ + id: state('listbox-group'), + ref: state(document.createElement('div')) + }); + vi.spyOn(ListboxGroupProvider, 'require').mockReturnValue(group); + const label = ListboxGroupLabelProvider.create({ + id: state('listbox-group-label'), + ref: state(document.createElement('div')) + }); + return { item, indicator, group, label }; + }); + + expect(result.item.props).toMatchObject({ + 'aria-selected': true, + 'data-state': 'selected' + }); + expect(result.indicator.isPresent).toBe(true); + expect(result.indicator.props).toMatchObject({ + 'aria-hidden': true, + 'data-state': 'selected' + }); + expect(result.group.props).toMatchObject({ + role: 'group', + 'aria-labelledby': 'listbox-group-label' + }); + expect(result.label.props.id).toBe('listbox-group-label'); + + cleanup(); + dom.dispose(); + }); +});