From 5971d6233d0ac8fc503a5047e0bf10343e7cac4e Mon Sep 17 00:00:00 2001 From: dev Date: Fri, 15 May 2026 22:13:48 +0200 Subject: [PATCH] Add time range field provider coverage --- continue.md | 5 +- src/uix/soma/SOMA_ARCHITECTURE.md | 9 +- .../time-range-field-provider.svelte.test.ts | 158 ++++++++++++++++++ 3 files changed, 168 insertions(+), 4 deletions(-) create mode 100644 src/uix/soma/components/time-range-field/time-range-field-provider.svelte.test.ts diff --git a/continue.md b/continue.md index 082e4ca10..e8ec7c70d 100644 --- a/continue.md +++ b/continue.md @@ -29,9 +29,11 @@ Actualizacion 2026-05-15: valor compartido. - Cobertura nueva para TimeRangePicker: valores por endpoint, sliders y cierre al completar ambos extremos. + - Cobertura nueva para TimeRangeField: validación de rango y foco de label + via `ActiveDom`. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - - `npm run test` -> 181 archivos, 2068 tests OK. + - `npm run test` -> 182 archivos, 2071 tests OK. - tests focales de Select/Popover/Toast/RangeCalendar -> 11 tests OK. - tests focales Dialog/Drawer/Popover/Select -> 10 tests OK. - `command-provider.svelte.test.ts` -> 2 tests OK. @@ -40,6 +42,7 @@ Actualizacion 2026-05-15: - `combobox-provider.svelte.test.ts` -> 3 tests OK. - tests focales DatePicker/DateRangePicker/TimePicker -> 7 tests OK. - `time-range-picker-provider.svelte.test.ts` -> 3 tests OK. + - `time-range-field-provider.svelte.test.ts` -> 3 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index 1cd565f43..ac0b4650b 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -471,10 +471,13 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A valores de placeholder y escritura de sliders al valor compartido. - `time-range-picker/time-range-picker-provider.svelte.test.ts` — valores por endpoint, escritura de sliders y cierre al completar rango. +- `time-range-field/time-range-field-provider.svelte.test.ts` — validación de + orden/min/max, validación custom y foco de label via `ActiveDom`. -Pendiente: ampliar cobertura a los providers internos de fecha/hora de mayor -tamano. `table-core`, `form-core` y el scorer de Command ya no viven dentro de -Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. +Pendiente: ampliar cobertura a `TimeField` y `DateRangeField`, los providers +internos de fecha/hora de mayor tamano. `table-core`, `form-core` y el scorer +de Command ya no viven dentro de Soma: se consumen desde `$libs/datagrid`, +`$libs/forms` y `$libs/strings`. ### Convencion diff --git a/src/uix/soma/components/time-range-field/time-range-field-provider.svelte.test.ts b/src/uix/soma/components/time-range-field/time-range-field-provider.svelte.test.ts new file mode 100644 index 000000000..f161601ca --- /dev/null +++ b/src/uix/soma/components/time-range-field/time-range-field-provider.svelte.test.ts @@ -0,0 +1,158 @@ +// @vitest-environment jsdom + +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { Time } from '$libs/days'; +import type { + EditableTimeSegmentPart, + HourCycle, + TimeGranularity, + TimeOnInvalid, + TimeRange, + TimeRangeValidator, + TimeValue +} from '$libs/days'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; +import type { Direction } from '../../types'; +import { FieldProvider } from '../field/field-provider.svelte'; + +import { + TimeRangeFieldLabelProvider, + TimeRangeFieldProvider +} from './time-range-field-provider.svelte'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness() { + const dom = createActiveDom(); + const soma = { + dom, + langs: { + getLocale: () => 'en-US', + ts: (key: string) => key + }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(FieldProvider, 'get').mockReturnValue(undefined); + vi.spyOn(TimeRangeFieldProvider.ctx, 'set').mockImplementation((value) => value); + + return { dom }; +} + +function createTimeRangeFieldOpts(root = document.createElement('div')) { + return { + id: state('time-range-field-root'), + ref: state(root), + value: state({ start: undefined, end: undefined }), + placeholder: state(new Time(9, 0)), + startValue: state(undefined), + endValue: state(undefined), + validate: state(undefined), + onInvalid: state(undefined), + minValue: state(undefined), + maxValue: state(undefined), + disabled: state(false), + readonly: state(false), + startReadonlySegments: state([]), + endReadonlySegments: state([]), + required: state(false), + granularity: state(undefined), + hideTimeZone: state(false), + hourCycle: state(undefined), + locale: state('en-US'), + dir: state('ltr'), + errorMessageId: state(undefined) + }; +} + +describe('TimeRangeFieldProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('validates endpoint ordering and min/max bounds', () => { + const { dom } = installSomaHarness(); + const opts = createTimeRangeFieldOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => TimeRangeFieldProvider.create(opts)); + + opts.value.current = { start: new Time(10, 0), end: new Time(9, 0) }; + expect(provider.validationStatus).toEqual({ reason: 'invalid' }); + expect(provider.isInvalid).toBe(true); + + opts.value.current = { start: new Time(8, 0), end: new Time(10, 0) }; + opts.minValue.current = new Time(9, 0); + expect(provider.validationStatus).toEqual({ reason: 'min' }); + + opts.minValue.current = undefined; + opts.maxValue.current = new Time(17, 0); + opts.value.current = { start: new Time(10, 0), end: new Time(18, 0) }; + expect(provider.validationStatus).toEqual({ reason: 'max' }); + + cleanup(); + dom.dispose(); + }); + + it('prefers custom validation when both endpoints are present', () => { + const { dom } = installSomaHarness(); + const opts = createTimeRangeFieldOpts(); + opts.value.current = { start: new Time(9, 0), end: new Time(10, 0) }; + opts.validate.current = () => 'Blocked range'; + + const { result: provider, cleanup } = withEffectRoot(() => TimeRangeFieldProvider.create(opts)); + + expect(provider.validationStatus).toEqual({ + reason: 'custom', + message: 'Blocked range' + }); + expect(provider.props['aria-invalid']).toBe(true); + + cleanup(); + dom.dispose(); + }); + + it('focuses the first start segment when the label is clicked', () => { + const { dom } = installSomaHarness(); + const root = document.createElement('div'); + root.innerHTML = '
'; + document.body.appendChild(root); + const opts = createTimeRangeFieldOpts(root); + const focus = vi.spyOn(dom, 'focus'); + + const { result: provider, cleanup } = withEffectRoot(() => { + const p = TimeRangeFieldProvider.create(opts); + vi.spyOn(TimeRangeFieldProvider.ctx, 'get').mockReturnValue(p); + const label = TimeRangeFieldLabelProvider.create({ + id: state('time-range-label'), + ref: state(document.createElement('label')) + }); + p.startInputId.current = 'start-input'; + label.onclick(); + return p; + }); + + expect(provider.startInputId.current).toBe('start-input'); + expect(focus).toHaveBeenCalledWith(root.querySelector('#start-hour')); + + cleanup(); + dom.dispose(); + }); +});