diff --git a/continue.md b/continue.md index be0bd2e3d..d1a1ff18d 100644 --- a/continue.md +++ b/continue.md @@ -61,9 +61,11 @@ Actualizacion 2026-05-15: area 2D, slider de canal y swatches con commit/cierre. - Cobertura nueva para NavigationMenu: timers UIX de apertura/cierre, enlace item/trigger/content, foco por teclado, list y link props. + - Cobertura nueva para TreeGrid: expansión, selección/rango, filas visibles + bajo ancestros colapsados, navegación, row/cell/header y expand trigger. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - - `npm run test` -> 191 archivos, 2105 tests OK. + - `npm run test` -> 192 archivos, 2109 tests OK. - tests focales de Select/Popover/Toast/RangeCalendar -> 11 tests OK. - tests focales Dialog/Drawer/Popover/Select -> 10 tests OK. - `command-provider.svelte.test.ts` -> 2 tests OK. @@ -83,6 +85,7 @@ Actualizacion 2026-05-15: - `color-field-provider.svelte.test.ts` -> 4 tests OK. - `color-picker-provider.svelte.test.ts` -> 4 tests OK. - `navigation-menu-provider.svelte.test.ts` -> 4 tests OK. + - `tree-grid-provider.svelte.test.ts` -> 4 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index e6bb3bf57..b6038b9ec 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -493,12 +493,14 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A trigger/value/hidden, area 2D, slider de canal y swatches. - `navigation-menu/navigation-menu-provider.svelte.test.ts` — timers UIX, enlace item/trigger/content, foco por teclado y props de list/link. +- `tree-grid/tree-grid-provider.svelte.test.ts` — expansión, selección/rango, + filas visibles, navegación y props de row/cell/header/expand trigger. Pendiente: seguir ampliando cobertura por familias de alto riesgo fuera del bloque fecha/hora, virtualización, inputs numericos, file upload, color y -navegacion superior. `table-core`, `form-core` y el scorer de Command ya no -viven dentro de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y -`$libs/strings`. +navegacion superior/treegrid. `table-core`, `form-core` y el scorer de Command +ya no viven dentro de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` +y `$libs/strings`. ### Convencion diff --git a/src/uix/soma/components/tree-grid/tree-grid-provider.svelte.test.ts b/src/uix/soma/components/tree-grid/tree-grid-provider.svelte.test.ts new file mode 100644 index 000000000..d27ea5bdc --- /dev/null +++ b/src/uix/soma/components/tree-grid/tree-grid-provider.svelte.test.ts @@ -0,0 +1,320 @@ +// @vitest-environment jsdom + +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; + +import { + TreeGridCellProvider, + TreeGridColumnHeaderProvider, + TreeGridExpandTriggerProvider, + TreeGridHeaderProvider, + TreeGridProvider, + TreeGridRowChildrenProvider, + TreeGridRowProvider +} from './tree-grid-provider.svelte'; +import type { TreeGridSelectionMode } from './types'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness() { + const dom = createActiveDom(); + const timers = { + schedule: vi.fn((_key: string, _delay: number, _callback: () => void) => ({ + cancel: vi.fn() + })) + }; + const soma = { + dom, + langs: { + ts: (key: string) => key + }, + prefs: { + getDir: () => 'ltr' + }, + uix: { + timers + }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(TreeGridProvider.ctx, 'set').mockImplementation((value) => value); + vi.spyOn(TreeGridRowProvider.ctx, 'set').mockImplementation((value) => value); + vi.spyOn(TreeGridRowProvider.ctx, 'getOr').mockReturnValue(undefined); + + return { dom, timers }; +} + +function createTreeGridOpts(root: HTMLElement = document.createElement('div')) { + return { + id: state('tree-grid-root'), + ref: state(root), + expanded: state([]), + value: state([]), + selectionMode: state('multiple'), + loop: state(false), + typeahead: state(true), + typeaheadTimeout: state(500), + disabled: state(false), + readonly: state(false), + ariaLabel: state(undefined), + ariaLabelledby: state(undefined), + onValueChange: state<((value: string[]) => void) | undefined>(undefined), + onExpandedChange: state<((value: string[]) => void) | undefined>(undefined) + }; +} + +function rowOpts(id: string, value: string, el: HTMLElement = document.createElement('div')) { + return { + id: state(id), + ref: state(el), + value: state(value), + hasChildren: state(false), + disabled: state(false), + textValue: state(value) + }; +} + +function applyAttrs(el: HTMLElement, props: Record) { + for (const [key, value] of Object.entries(props)) { + if (!key.startsWith('data-') && key !== 'role' && key !== 'id') continue; + if (value === undefined || value === false || typeof value === 'function') continue; + el.setAttribute(key, value === true ? '' : String(value)); + } +} + +function keyEvent(key: string, currentTarget: HTMLElement, extras: Record = {}) { + return { + key, + currentTarget, + preventDefault: vi.fn(), + ctrlKey: false, + metaKey: false, + shiftKey: false, + altKey: false, + ...extras + }; +} + +describe('TreeGridProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('expands, collapses, selects ranges and exposes root snippet state', () => { + const { dom } = installSomaHarness(); + const root = document.createElement('div'); + document.body.appendChild(root); + const opts = createTreeGridOpts(root); + const onExpandedChange = vi.fn(); + const onValueChange = vi.fn(); + opts.onExpandedChange.current = onExpandedChange; + opts.onValueChange.current = onValueChange; + + const { result: provider, cleanup } = withEffectRoot(() => TreeGridProvider.create(opts)); + applyAttrs(root, provider.props); + + for (const value of ['a', 'b', 'c']) { + const row = document.createElement('div'); + row.setAttribute('data-tree-grid-row', ''); + row.setAttribute('data-value', value); + root.appendChild(row); + } + + provider.expand('a'); + provider.toggleExpand('a'); + expect(opts.expanded.current).toEqual([]); + expect(onExpandedChange).toHaveBeenNthCalledWith(1, ['a']); + expect(onExpandedChange).toHaveBeenNthCalledWith(2, []); + + provider.select('a', 'replace'); + provider.select('c', 'range'); + + expect(opts.value.current).toEqual(['a', 'b', 'c']); + expect(onValueChange).toHaveBeenLastCalledWith(['a', 'b', 'c']); + expect(provider.snippetProps.selected).toEqual(['a', 'b', 'c']); + + provider.clear(); + expect(opts.value.current).toEqual([]); + + cleanup(); + dom.dispose(); + }); + + it('filters visible rows under collapsed ancestors and navigates with arrows', () => { + const { dom } = installSomaHarness(); + const focus = vi.spyOn(dom, 'focus'); + const root = document.createElement('div'); + document.body.appendChild(root); + const opts = createTreeGridOpts(root); + opts.expanded.current = []; + + const { result, cleanup } = withEffectRoot(() => { + const provider = TreeGridProvider.create(opts); + vi.spyOn(TreeGridProvider.ctx, 'get').mockReturnValue(provider); + applyAttrs(root, provider.props); + + const parentEl = document.createElement('div'); + const groupEl = document.createElement('div'); + const childEl = document.createElement('div'); + const siblingEl = document.createElement('div'); + root.append(parentEl, siblingEl); + parentEl.appendChild(groupEl); + groupEl.appendChild(childEl); + + const parent = TreeGridRowProvider.create({ + ...rowOpts('tree-grid-parent', 'parent', parentEl), + hasChildren: state(true) + }); + applyAttrs(parentEl, parent.props); + vi.spyOn(TreeGridRowProvider.ctx, 'get').mockReturnValue(parent); + const group = TreeGridRowChildrenProvider.create({ + id: state('tree-grid-parent-children'), + ref: state(groupEl) + }); + applyAttrs(groupEl, group.props); + const child = TreeGridRowProvider.create(rowOpts('tree-grid-child', 'child', childEl)); + applyAttrs(childEl, child.props); + const sibling = TreeGridRowProvider.create( + rowOpts('tree-grid-sibling', 'sibling', siblingEl) + ); + applyAttrs(siblingEl, sibling.props); + + return { provider, parentEl, childEl, siblingEl }; + }); + + expect(result.provider.getVisibleRows()).toEqual([result.parentEl, result.siblingEl]); + + result.provider.handleRowKeydown(keyEvent('ArrowRight', result.parentEl) as never); + expect(opts.expanded.current).toEqual(['parent']); + result.parentEl.setAttribute('data-expanded', 'true'); + + expect(result.provider.getVisibleRows()).toEqual([ + result.parentEl, + result.childEl, + result.siblingEl + ]); + + result.provider.handleRowKeydown(keyEvent('ArrowDown', result.parentEl) as never); + expect(focus).toHaveBeenCalledWith(result.childEl); + + result.provider.handleRowKeydown(keyEvent('ArrowLeft', result.childEl) as never); + expect(focus).toHaveBeenCalledWith(result.parentEl); + + cleanup(); + dom.dispose(); + }); + + it('builds row, cell, header and expand trigger props from provider state', () => { + const { dom } = installSomaHarness(); + const opts = createTreeGridOpts(); + opts.expanded.current = ['folder']; + opts.value.current = ['folder']; + + const { result, cleanup } = withEffectRoot(() => { + const provider = TreeGridProvider.create(opts); + vi.spyOn(TreeGridProvider.ctx, 'get').mockReturnValue(provider); + const row = TreeGridRowProvider.create({ + ...rowOpts('tree-grid-folder', 'folder'), + hasChildren: state(true) + }); + vi.spyOn(TreeGridRowProvider.ctx, 'get').mockReturnValue(row); + const trigger = TreeGridExpandTriggerProvider.create({ + id: state('tree-grid-folder-expand'), + ref: state(null), + ariaLabel: state(undefined) + }); + const header = TreeGridHeaderProvider.create({ + id: state('tree-grid-header'), + ref: state(null) + }); + const columnHeader = TreeGridColumnHeaderProvider.create({ + id: state('tree-grid-column-header'), + ref: state(null) + }); + const cell = TreeGridCellProvider.create({ + id: state('tree-grid-cell'), + ref: state(null) + }); + return { row, trigger, header, columnHeader, cell }; + }); + + expect(result.row.snippetProps).toMatchObject({ + expanded: true, + selected: true, + level: 1, + hasChildren: true + }); + expect(result.row.props).toMatchObject({ + role: 'row', + 'aria-expanded': true, + 'aria-selected': true, + 'data-state': 'selected', + 'data-expanded': 'true', + 'data-level': 1 + }); + expect(result.trigger.props).toMatchObject({ + type: 'button', + tabindex: -1, + 'data-state': 'open', + 'aria-label': '#?components.tree-grid.collapse|Collapse row' + }); + expect(result.header.props.role).toBe('row'); + expect(result.columnHeader.props.role).toBe('columnheader'); + expect(result.cell.props.role).toBe('gridcell'); + + cleanup(); + dom.dispose(); + }); + + it('handles row click modes, selectAll and disabled guards', () => { + const { dom } = installSomaHarness(); + const root = document.createElement('div'); + document.body.appendChild(root); + const opts = createTreeGridOpts(root); + const onValueChange = vi.fn(); + opts.onValueChange.current = onValueChange; + + const { result: provider, cleanup } = withEffectRoot(() => TreeGridProvider.create(opts)); + applyAttrs(root, provider.props); + + for (const value of ['a', 'b']) { + const row = document.createElement('div'); + row.setAttribute('data-tree-grid-row', ''); + row.setAttribute('data-value', value); + root.appendChild(row); + } + + provider.selectAll(); + expect(opts.value.current).toEqual(['a', 'b']); + + provider.handleRowClick('a', keyEvent('click', root, { ctrlKey: true }) as never); + expect(opts.value.current).toEqual(['b']); + + opts.disabled.current = true; + provider.select('c', 'replace'); + provider.toggleExpand('c'); + expect(opts.value.current).toEqual(['b']); + expect(opts.expanded.current).toEqual([]); + + cleanup(); + dom.dispose(); + }); +});