diff --git a/continue.md b/continue.md index 1347d1125..c7853a6db 100644 --- a/continue.md +++ b/continue.md @@ -127,9 +127,11 @@ Actualizacion 2026-05-15: PageUp/PageDown, threads anidados y sentinel IntersectionObserver. - Cobertura nueva para TagsInput: add/paste/blur, navegación de tags, delete/clear triggers y props de input/control. + - Cobertura nueva para Editable: activación preview/trigger, foco via + `ActiveDom`, commit/cancel por teclado/blur y guards disabled/readonly. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - - `npm run test` -> 224 archivos, 2221 tests OK. + - `npm run test` -> 225 archivos, 2224 tests OK. - tests focales de Select/Popover/Toast/RangeCalendar -> 11 tests OK. - tests focales Dialog/Drawer/Popover/Select -> 10 tests OK. - `command-provider.svelte.test.ts` -> 2 tests OK. @@ -182,6 +184,7 @@ Actualizacion 2026-05-15: - `announce-provider.svelte.test.ts` -> 3 tests OK. - `feed-provider.svelte.test.ts` -> 3 tests OK. - `tags-input-provider.svelte.test.ts` -> 3 tests OK. + - `editable-provider.svelte.test.ts` -> 3 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index 34ad8a60c..7e1d76366 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -559,6 +559,8 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A navegación PageUp/PageDown, threads anidados y sentinel IntersectionObserver. - `tags-input/tags-input-provider.svelte.test.ts` — add/paste/blur, navegación de tags, delete/clear triggers y props de input/control. +- `editable/editable-provider.svelte.test.ts` — activación preview/trigger, + foco via `ActiveDom`, commit/cancel por teclado/blur y guards. Pendiente: seguir ampliando cobertura por el resto del catalogo Soma, ya por componentes de riesgo medio y familias menos centrales. `table-core`, diff --git a/src/uix/soma/components/editable/editable-provider.svelte.test.ts b/src/uix/soma/components/editable/editable-provider.svelte.test.ts new file mode 100644 index 000000000..ed34da450 --- /dev/null +++ b/src/uix/soma/components/editable/editable-provider.svelte.test.ts @@ -0,0 +1,294 @@ +// @vitest-environment jsdom + +import { tick } from 'svelte'; +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; + +import { + EditableAreaProvider, + EditableCancelTriggerProvider, + EditableEditTriggerProvider, + EditableInputProvider, + EditablePreviewProvider, + EditableProvider, + EditableSubmitTriggerProvider +} from './editable-provider.svelte'; +import type { ActivationMode, SubmitMode } from './types'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness() { + const dom = createActiveDom(); + const soma = { + dom, + langs: { + ts: vi.fn((key: string) => { + if (key.includes('save')) return 'Save'; + if (key.includes('cancel')) return 'Cancel'; + return 'Edit'; + }) + }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(EditableProvider.ctx, 'set').mockImplementation((value) => value); + + return { dom }; +} + +function editableOpts(root = document.createElement('div')) { + return { + id: state('editable-root'), + ref: state(root), + value: state('Hello'), + editing: state(false), + placeholder: state('Untitled'), + activationMode: state('click'), + submitMode: state('enter'), + selectOnFocus: state(true), + autoResize: state(true), + maxLength: state(20), + disabled: state(false), + readonly: state(false), + onValueCommit: state(vi.fn()), + onValueRevert: state(vi.fn()) + }; +} + +function keyEvent(key: string, shiftKey = false) { + return { + key, + shiftKey, + preventDefault: vi.fn() + }; +} + +function inputEvent(input: HTMLInputElement) { + return { + currentTarget: input + }; +} + +describe('EditableProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('starts editing, focuses the input and projects provider/area state attrs', async () => { + const { dom } = installSomaHarness(); + let scheduledFrame: FrameRequestCallback | undefined; + const requestFrame = vi.spyOn(dom, 'requestFrame').mockImplementation((callback) => { + scheduledFrame = callback; + return 42; + }); + const focusSpy = vi.spyOn(dom, 'focus'); + const root = document.createElement('div'); + const areaEl = document.createElement('div'); + const inputEl = document.createElement('input'); + const selectSpy = vi.spyOn(inputEl, 'select'); + root.append(areaEl, inputEl); + document.body.appendChild(root); + const opts = editableOpts(root); + + const { result, cleanup } = withEffectRoot(() => { + const provider = EditableProvider.create(opts); + vi.spyOn(EditableProvider, 'require').mockReturnValue(provider); + const area = EditableAreaProvider.create({ + id: state('editable-area'), + ref: state(areaEl) + }); + const input = EditableInputProvider.create({ + id: state('editable-input'), + ref: state(inputEl) + }); + provider.inputRef.current = inputEl; + return { provider, area, input }; + }); + + result.provider.startEdit(); + expect(opts.editing.current).toBe(true); + expect(result.provider.draft).toBe('Hello'); + expect(requestFrame).toHaveBeenCalledOnce(); + scheduledFrame?.(performance.now()); + expect(focusSpy).toHaveBeenCalledWith(inputEl); + expect(selectSpy).toHaveBeenCalledOnce(); + + expect(result.input.props).toMatchObject({ + id: 'editable-input', + hidden: undefined, + value: 'Hello', + placeholder: 'Untitled', + maxlength: 20, + style: { + 'field-sizing': 'content', + 'min-width': '2ch' + } + }); + + await tick(); + expect(root.getAttribute('data-editing')).toBe(''); + expect(root.hasAttribute('data-empty')).toBe(false); + expect(areaEl.getAttribute('data-editing')).toBe(''); + expect(areaEl.hasAttribute('data-disabled')).toBe(false); + + cleanup(); + dom.dispose(); + }); + + it('handles preview activation, keyboard submit/cancel and blur control guards', () => { + const { dom } = installSomaHarness(); + vi.spyOn(dom, 'requestFrame').mockReturnValue(1); + const root = document.createElement('div'); + const previewEl = document.createElement('div'); + const inputEl = document.createElement('input'); + root.append(previewEl, inputEl); + document.body.appendChild(root); + const opts = editableOpts(root); + + const { result, cleanup } = withEffectRoot(() => { + const provider = EditableProvider.create(opts); + vi.spyOn(EditableProvider, 'require').mockReturnValue(provider); + const preview = EditablePreviewProvider.create({ + id: state('editable-preview'), + ref: state(previewEl) + }); + const input = EditableInputProvider.create({ + id: state('editable-input'), + ref: state(inputEl) + }); + provider.inputRef.current = inputEl; + return { provider, preview, input }; + }); + + result.preview.onclick({ currentTarget: previewEl } as never); + expect(opts.editing.current).toBe(true); + expect(result.preview.props.hidden).toBe(true); + + inputEl.value = 'Draft'; + result.input.oninput(inputEvent(inputEl) as never); + const enter = keyEvent('Enter'); + result.input.onkeydown(enter as never); + expect(enter.preventDefault).toHaveBeenCalledOnce(); + expect(opts.value.current).toBe('Draft'); + expect(opts.editing.current).toBe(false); + expect(opts.onValueCommit.current).toHaveBeenLastCalledWith('Draft'); + + result.provider.startEdit(); + inputEl.value = 'Reverted'; + result.input.oninput(inputEvent(inputEl) as never); + const escape = keyEvent('Escape'); + result.input.onkeydown(escape as never); + expect(escape.preventDefault).toHaveBeenCalledOnce(); + expect(opts.value.current).toBe('Draft'); + expect(result.provider.draft).toBe('Draft'); + expect(opts.onValueRevert.current).toHaveBeenCalledOnce(); + + opts.activationMode.current = 'dblclick'; + result.preview.onclick({ currentTarget: previewEl } as never); + expect(opts.editing.current).toBe(false); + result.preview.ondblclick({ currentTarget: previewEl } as never); + expect(opts.editing.current).toBe(true); + + opts.submitMode.current = 'blur'; + inputEl.value = 'Held'; + result.input.oninput(inputEvent(inputEl) as never); + const submitTrigger = document.createElement('button'); + submitTrigger.setAttribute('data-editable-submit-trigger', ''); + result.input.onblur({ relatedTarget: submitTrigger } as unknown as FocusEvent); + expect(opts.editing.current).toBe(true); + expect(opts.value.current).toBe('Draft'); + + result.input.onblur({ relatedTarget: null } as unknown as FocusEvent); + expect(opts.editing.current).toBe(false); + expect(opts.value.current).toBe('Held'); + + cleanup(); + dom.dispose(); + }); + + it('exposes trigger labels and guards disabled or readonly edits', () => { + const { dom } = installSomaHarness(); + vi.spyOn(dom, 'requestFrame').mockReturnValue(1); + const root = document.createElement('div'); + const editEl = document.createElement('button'); + const submitEl = document.createElement('button'); + const cancelEl = document.createElement('button'); + root.append(editEl, submitEl, cancelEl); + document.body.appendChild(root); + const opts = editableOpts(root); + + const { result, cleanup } = withEffectRoot(() => { + const provider = EditableProvider.create(opts); + vi.spyOn(EditableProvider, 'require').mockReturnValue(provider); + const edit = EditableEditTriggerProvider.create({ + id: state('editable-edit'), + ref: state(editEl) + }); + const submit = EditableSubmitTriggerProvider.create({ + id: state('editable-submit'), + ref: state(submitEl) + }); + const cancel = EditableCancelTriggerProvider.create({ + id: state('editable-cancel'), + ref: state(cancelEl) + }); + return { provider, edit, submit, cancel }; + }); + + expect(result.edit.props).toMatchObject({ + type: 'button', + hidden: undefined, + 'aria-label': 'Edit' + }); + expect(result.submit.props.hidden).toBe(true); + expect(result.cancel.props.hidden).toBe(true); + + result.edit.onclick({ currentTarget: editEl } as never); + expect(opts.editing.current).toBe(true); + expect(result.edit.props.hidden).toBe(true); + expect(result.submit.props).toMatchObject({ + hidden: undefined, + 'aria-label': 'Save' + }); + expect(result.cancel.props).toMatchObject({ + hidden: undefined, + 'aria-label': 'Cancel' + }); + + result.submit.onclick({ currentTarget: submitEl } as never); + expect(opts.editing.current).toBe(false); + expect(opts.onValueCommit.current).toHaveBeenLastCalledWith('Hello'); + + opts.readonly.current = true; + expect(result.edit.props.disabled).toBe(true); + result.edit.onclick({ currentTarget: editEl } as never); + expect(opts.editing.current).toBe(false); + + opts.readonly.current = false; + opts.disabled.current = true; + expect(result.cancel.props.disabled).toBe(true); + result.provider.startEdit(); + expect(opts.editing.current).toBe(false); + + cleanup(); + dom.dispose(); + }); +});