From 37cd177c3780c841ab2469b8a270079fc14d44e4 Mon Sep 17 00:00:00 2001 From: dev Date: Fri, 15 May 2026 23:56:50 +0200 Subject: [PATCH] Add checkbox provider coverage --- continue.md | 5 +- src/uix/soma/SOMA_ARCHITECTURE.md | 7 +- .../checkbox/checkbox-provider.svelte.test.ts | 229 ++++++++++++++++++ 3 files changed, 238 insertions(+), 3 deletions(-) create mode 100644 src/uix/soma/components/checkbox/checkbox-provider.svelte.test.ts diff --git a/continue.md b/continue.md index 040b7a85d..6195aa6a0 100644 --- a/continue.md +++ b/continue.md @@ -76,9 +76,11 @@ Actualizacion 2026-05-15: typeahead, props de ramas/hojas y partes auxiliares. - Cobertura nueva para Accordion: modo single/multiple, eventos open/close por item, navegación de triggers y props de header/content. + - Cobertura nueva para Checkbox: commits check/uncheck, estado indeterminate, + hidden input y sincronización con CheckboxGroup. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - - `npm run test` -> 198 archivos, 2137 tests OK. + - `npm run test` -> 199 archivos, 2141 tests OK. - tests focales de Select/Popover/Toast/RangeCalendar -> 11 tests OK. - tests focales Dialog/Drawer/Popover/Select -> 10 tests OK. - `command-provider.svelte.test.ts` -> 2 tests OK. @@ -105,6 +107,7 @@ Actualizacion 2026-05-15: - `listbox-provider.svelte.test.ts` -> 4 tests OK. - `tree-view-provider.svelte.test.ts` -> 4 tests OK. - `accordion-provider.svelte.test.ts` -> 4 tests OK. + - `checkbox-provider.svelte.test.ts` -> 4 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index 6b7a8d1c7..621128149 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -508,12 +508,15 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A navegación root, typeahead, props de ramas/hojas y partes auxiliares. - `accordion/accordion-provider.svelte.test.ts` — modos single/multiple, eventos `open/close` por item, navegación de triggers y header/content. +- `checkbox/checkbox-provider.svelte.test.ts` — commits check/uncheck, + indeterminate, hidden input y sincronización con `CheckboxGroup`. Pendiente: seguir ampliando cobertura por familias de alto riesgo fuera del bloque fecha/hora, virtualización, inputs numericos, file upload, color y navegacion superior/treegrid/tree-view/dropdown/context-menu/menubar/listbox/ -accordion. `table-core`, `form-core` y el scorer de Command ya no viven dentro -de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. +accordion/checkbox. `table-core`, `form-core` y el scorer de Command ya no +viven dentro de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y +`$libs/strings`. ### Convencion diff --git a/src/uix/soma/components/checkbox/checkbox-provider.svelte.test.ts b/src/uix/soma/components/checkbox/checkbox-provider.svelte.test.ts new file mode 100644 index 000000000..961cacf80 --- /dev/null +++ b/src/uix/soma/components/checkbox/checkbox-provider.svelte.test.ts @@ -0,0 +1,229 @@ +// @vitest-environment jsdom + +import { flushSync, tick } from 'svelte'; +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; + +import { + CheckboxGroupLabelProvider, + CheckboxGroupProvider, + CheckboxHiddenInputProvider, + CheckboxIndicatorProvider, + CheckboxProvider +} from './checkbox-provider.svelte'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +async function flushRuntimeTrigger() { + await Promise.resolve(); + await tick(); +} + +function installSomaHarness() { + const dom = createActiveDom(); + const soma = { + dom, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(CheckboxProvider.ctx, 'set').mockImplementation((value) => value); + vi.spyOn(CheckboxGroupProvider.ctx, 'set').mockImplementation((value) => value); + vi.spyOn(CheckboxGroupProvider, 'get').mockReturnValue(undefined); + + return { dom }; +} + +function checkboxOpts(id = 'checkbox-root') { + return { + id: state(id), + ref: state(document.createElement('button')), + checked: state(false), + indeterminate: state(false), + disabled: state(false), + required: state(false), + readonly: state(false), + invalid: state(false), + name: state(''), + value: state('on') + }; +} + +function groupOpts() { + return { + id: state('checkbox-group'), + ref: state(document.createElement('div')), + value: state([]), + disabled: state(false), + required: state(false), + name: state(''), + orientation: state<'horizontal' | 'vertical'>('vertical') + }; +} + +function partOpts(id: string, el: HTMLElement = document.createElement('span')) { + return { + id: state(id), + ref: state(el) + }; +} + +function keyEvent(key: string, currentTarget: HTMLElement) { + return { + key, + currentTarget, + preventDefault: vi.fn() + }; +} + +describe('CheckboxProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('commits checked state through runtime events and clears indeterminate', async () => { + const { dom } = installSomaHarness(); + const opts = checkboxOpts(); + opts.indeterminate.current = true; + + const { result, cleanup } = withEffectRoot(() => { + const provider = CheckboxProvider.create(opts); + vi.spyOn(CheckboxProvider.ctx, 'get').mockReturnValue(provider); + const indicator = CheckboxIndicatorProvider.create(partOpts('checkbox-indicator')); + return { provider, indicator }; + }); + + expect(result.provider.dataState).toBe('indeterminate'); + expect(result.indicator.isVisible).toBe(true); + + result.provider.toggle(opts.ref.current ?? undefined); + await flushRuntimeTrigger(); + expect(opts.indeterminate.current).toBe(false); + expect(opts.checked.current).toBe(false); + expect(result.provider.dataState).toBe('unchecked'); + expect(result.indicator.isVisible).toBe(false); + + const event = keyEvent(' ', opts.ref.current!); + result.provider.onkeydown(event as never); + await flushRuntimeTrigger(); + expect(event.preventDefault).toHaveBeenCalledOnce(); + expect(opts.checked.current).toBe(true); + expect(result.provider.dataState).toBe('checked'); + + cleanup(); + dom.dispose(); + }); + + it('does not toggle when readonly or disabled', async () => { + const { dom } = installSomaHarness(); + const opts = checkboxOpts(); + opts.readonly.current = true; + + const { result: provider, cleanup } = withEffectRoot(() => CheckboxProvider.create(opts)); + + provider.toggle(opts.ref.current ?? undefined); + await flushRuntimeTrigger(); + expect(opts.checked.current).toBe(false); + + opts.readonly.current = false; + opts.disabled.current = true; + provider.toggle(opts.ref.current ?? undefined); + await flushRuntimeTrigger(); + expect(opts.checked.current).toBe(false); + expect(provider.props.disabled).toBe(true); + + cleanup(); + dom.dispose(); + }); + + it('exposes hidden input props from own and group state', async () => { + const { dom } = installSomaHarness(); + const opts = checkboxOpts(); + opts.name.current = 'standalone'; + opts.value.current = 'yes'; + opts.required.current = true; + + const { result, cleanup } = withEffectRoot(() => { + const provider = CheckboxProvider.create(opts); + vi.spyOn(CheckboxProvider.ctx, 'get').mockReturnValue(provider); + const input = CheckboxHiddenInputProvider.create(partOpts('checkbox-hidden-input')); + return { input }; + }); + + expect(result.input.props).toMatchObject({ + type: 'checkbox', + tabindex: -1, + name: 'standalone', + value: 'yes', + checked: false, + required: true + }); + + opts.checked.current = true; + await tick(); + expect(result.input.props.checked).toBe(true); + + cleanup(); + dom.dispose(); + }); + + it('synchronizes with CheckboxGroup value and label context', async () => { + const { dom } = installSomaHarness(); + const groupState = groupOpts(); + groupState.value.current = ['alpha']; + groupState.name.current = 'features'; + groupState.required.current = true; + const opts = checkboxOpts('checkbox-alpha'); + opts.value.current = 'alpha'; + + const { result, cleanup } = withEffectRoot(() => { + const group = CheckboxGroupProvider.create(groupState); + vi.spyOn(CheckboxGroupProvider, 'get').mockReturnValue(group); + vi.spyOn(CheckboxGroupProvider, 'require').mockReturnValue(group); + const checkbox = CheckboxProvider.create(opts); + vi.spyOn(CheckboxProvider.ctx, 'get').mockReturnValue(checkbox); + const input = CheckboxHiddenInputProvider.create(partOpts('checkbox-alpha-input')); + const label = CheckboxGroupLabelProvider.create(partOpts('checkbox-group-label')); + return { group, checkbox, input, label }; + }); + flushSync(); + + expect(opts.checked.current).toBe(true); + expect(result.input.props).toMatchObject({ + name: 'features', + value: 'alpha', + checked: true, + required: true + }); + expect(result.label.props.id).toBe('checkbox-group-label'); + + result.checkbox.toggle(opts.ref.current ?? undefined); + await flushRuntimeTrigger(); + expect(opts.checked.current).toBe(false); + expect(groupState.value.current).toEqual([]); + + result.group.updateItemChecked('beta', true); + result.group.updateItemChecked('beta', true); + expect(groupState.value.current).toEqual(['beta']); + + cleanup(); + dom.dispose(); + }); +});