From 2d8599b62f2e47321af595b25d05fbdeee59b66f Mon Sep 17 00:00:00 2001
From: dev <info@activething.com>
Date: Sat, 23 May 2026 00:00:24 +0200
Subject: [PATCH] fix(dropdown-menu, context-menu): keep menu open on
 CheckboxItem / RadioItem activation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Soma's MenuCheckboxItem / MenuRadioItem default `closeOnSelect=true`
(matches Radix Primitives), but for toggle-state items that's the
wrong UX default — the user wants to flip multiple checkboxes or
switch a radio choice without re-opening the menu each time.

Override the default in the eidos wrappers for both DropdownMenu and
ContextMenu (4 components total: CheckboxItem + RadioItem in each).
Activating Item (plain command) still closes by default; only the
state-toggle parts stay open.

Consumers who genuinely want close-on-toggle can pass
`closeOnSelect={true}` explicitly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 .../context-menu-checkbox-item.svelte             |  8 +++++++-
 .../context-menu/context-menu-radio-item.svelte   | 13 +++++++++++--
 .../dropdown-menu-checkbox-item.svelte            | 11 ++++++++++-
 .../dropdown-menu/dropdown-menu-radio-item.svelte | 15 +++++++++++++--
 4 files changed, 41 insertions(+), 6 deletions(-)

diff --git a/src/uix/eidos/components/context-menu/context-menu-checkbox-item.svelte b/src/uix/eidos/components/context-menu/context-menu-checkbox-item.svelte
index 10476f612..52099b1e1 100644
--- a/src/uix/eidos/components/context-menu/context-menu-checkbox-item.svelte
+++ b/src/uix/eidos/components/context-menu/context-menu-checkbox-item.svelte
@@ -1,15 +1,21 @@
 <script lang="ts">
+	/**
+	 * Eidos `<ContextMenu.CheckboxItem>`. Defaults
+	 * `closeOnSelect={false}` because a checkbox is a state toggle, not
+	 * a one-shot action. Mirrors DropdownMenu.CheckboxItem.
+	 */
 	import * as ContextMenu from '$soma/components/context-menu';
 	import type { ContextMenuCheckboxItemProps } from './types';
 
 	let {
 		checked = $bindable(false),
+		closeOnSelect = false,
 		children: bodyContent,
 		...rest
 	}: ContextMenuCheckboxItemProps = $props();
 </script>
 
-<ContextMenu.CheckboxItem {...rest} bind:checked>
+<ContextMenu.CheckboxItem {...rest} {closeOnSelect} bind:checked>
 	{#snippet children(snippetProps)}
 		{@render bodyContent?.(snippetProps)}
 	{/snippet}
diff --git a/src/uix/eidos/components/context-menu/context-menu-radio-item.svelte b/src/uix/eidos/components/context-menu/context-menu-radio-item.svelte
index 4a97b14b2..5b55d7637 100644
--- a/src/uix/eidos/components/context-menu/context-menu-radio-item.svelte
+++ b/src/uix/eidos/components/context-menu/context-menu-radio-item.svelte
@@ -1,11 +1,20 @@
 <script lang="ts">
+	/**
+	 * Eidos `<ContextMenu.RadioItem>`. Defaults `closeOnSelect={false}`
+	 * — a radio is a state pick within a group. Mirrors
+	 * DropdownMenu.RadioItem.
+	 */
 	import * as ContextMenu from '$soma/components/context-menu';
 	import type { ContextMenuRadioItemProps } from './types';
 
-	let { children: bodyContent, ...rest }: ContextMenuRadioItemProps = $props();
+	let {
+		closeOnSelect = false,
+		children: bodyContent,
+		...rest
+	}: ContextMenuRadioItemProps = $props();
 </script>
 
-<ContextMenu.RadioItem {...rest}>
+<ContextMenu.RadioItem {...rest} {closeOnSelect}>
 	{#snippet children(snippetProps)}
 		{@render bodyContent?.(snippetProps)}
 	{/snippet}
diff --git a/src/uix/eidos/components/dropdown-menu/dropdown-menu-checkbox-item.svelte b/src/uix/eidos/components/dropdown-menu/dropdown-menu-checkbox-item.svelte
index d66ef0528..08b421b12 100644
--- a/src/uix/eidos/components/dropdown-menu/dropdown-menu-checkbox-item.svelte
+++ b/src/uix/eidos/components/dropdown-menu/dropdown-menu-checkbox-item.svelte
@@ -1,15 +1,24 @@
 <script lang="ts">
+	/**
+	 * Eidos `<DropdownMenu.CheckboxItem>`. Defaults
+	 * `closeOnSelect={false}` because a checkbox is a state toggle, not
+	 * a one-shot action — the user typically wants to toggle multiple
+	 * options without having to re-open the menu each time. Pass
+	 * `closeOnSelect` explicitly to override (Radix Primitives leaves
+	 * the close behaviour to the consumer; we pick the saner default).
+	 */
 	import * as DropdownMenu from '$soma/components/dropdown-menu';
 	import type { DropdownMenuCheckboxItemProps } from './types';
 
 	let {
 		checked = $bindable(false),
+		closeOnSelect = false,
 		children: bodyContent,
 		...rest
 	}: DropdownMenuCheckboxItemProps = $props();
 </script>
 
-<DropdownMenu.CheckboxItem {...rest} bind:checked>
+<DropdownMenu.CheckboxItem {...rest} {closeOnSelect} bind:checked>
 	{#snippet children(snippetProps)}
 		{@render bodyContent?.(snippetProps)}
 	{/snippet}
diff --git a/src/uix/eidos/components/dropdown-menu/dropdown-menu-radio-item.svelte b/src/uix/eidos/components/dropdown-menu/dropdown-menu-radio-item.svelte
index 949bc2ae9..e174a7647 100644
--- a/src/uix/eidos/components/dropdown-menu/dropdown-menu-radio-item.svelte
+++ b/src/uix/eidos/components/dropdown-menu/dropdown-menu-radio-item.svelte
@@ -1,11 +1,22 @@
 <script lang="ts">
+	/**
+	 * Eidos `<DropdownMenu.RadioItem>`. Defaults `closeOnSelect={false}`
+	 * — a radio is a state pick within a group, not a one-shot action.
+	 * Most consumers want the user to be able to switch the choice
+	 * without re-opening the menu. Pass `closeOnSelect` explicitly to
+	 * override.
+	 */
 	import * as DropdownMenu from '$soma/components/dropdown-menu';
 	import type { DropdownMenuRadioItemProps } from './types';
 
-	let { children: bodyContent, ...rest }: DropdownMenuRadioItemProps = $props();
+	let {
+		closeOnSelect = false,
+		children: bodyContent,
+		...rest
+	}: DropdownMenuRadioItemProps = $props();
 </script>
 
-<DropdownMenu.RadioItem {...rest}>
+<DropdownMenu.RadioItem {...rest} {closeOnSelect}>
 	{#snippet children(snippetProps)}
 		{@render bodyContent?.(snippetProps)}
 	{/snippet}