diff --git a/continue.md b/continue.md index 23d034e08..63a38bd01 100644 --- a/continue.md +++ b/continue.md @@ -22,6 +22,8 @@ Actualizacion 2026-05-15: `*-provider.svelte.ts` (excepto el wrapper Svelte publico de Select). - `Dismissal` y `SafePolygon` usan `uix.timers` cuando Soma lo tiene disponible, con fallback nativo solo para uso standalone fuera de UIX. + - Cobertura nueva para Combobox: selección single/multiple, `inputValue` y + filtrado de items disabled. - Validado por fase: - `npm run check` -> 0 errores, 0 warnings. - `npm run test` -> 176 archivos, 2055 tests OK. @@ -30,6 +32,7 @@ Actualizacion 2026-05-15: - `command-provider.svelte.test.ts` -> 2 tests OK. - `$libs/datagrid/table-core.svelte.test.ts` -> 8 tests OK. - `$libs/forms/form-core.svelte.test.ts` -> 3 tests OK. + - `combobox-provider.svelte.test.ts` -> 3 tests OK. - guardia `rg "from './.*provider\\.svelte'" src/uix/soma/components -g 'exports.ts'` -> solo queda `select/components/select-provider.svelte`, que es wrapper publico, no runtime provider. diff --git a/src/uix/soma/SOMA_ARCHITECTURE.md b/src/uix/soma/SOMA_ARCHITECTURE.md index f5c3898c7..418afdf8f 100644 --- a/src/uix/soma/SOMA_ARCHITECTURE.md +++ b/src/uix/soma/SOMA_ARCHITECTURE.md @@ -450,6 +450,8 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A persistent. - `command/command-provider.svelte.test.ts` — filtro, visibilidad, navegación y selección. +- `combobox/combobox-provider.svelte.test.ts` — selección, `inputValue` y + navegación sin items disabled. - `select/select-provider.svelte.test.ts` — selección single/multiple y navegación sin items disabled. - `popover/popover-provider.svelte.test.ts` — toggle, hover timers y señales @@ -462,10 +464,9 @@ Los tests por componente estan creciendo desde las piezas de mayor riesgo. A - `date-field/date-field-provider.svelte.test.ts` — helpers UI de segmentos, lectura DOM y navegación por `ActiveDom`. -Pendiente: ampliar cobertura a Combobox, DatePicker y los pickers/ranges de -fecha/hora restantes. `table-core`, `form-core` y el scorer de Command ya no -viven dentro de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y -`$libs/strings`. +Pendiente: ampliar cobertura a DatePicker y los pickers/ranges de fecha/hora +restantes. `table-core`, `form-core` y el scorer de Command ya no viven dentro +de Soma: se consumen desde `$libs/datagrid`, `$libs/forms` y `$libs/strings`. ### Convencion diff --git a/src/uix/soma/components/combobox/combobox-provider.svelte.test.ts b/src/uix/soma/components/combobox/combobox-provider.svelte.test.ts new file mode 100644 index 000000000..0f46ab0c4 --- /dev/null +++ b/src/uix/soma/components/combobox/combobox-provider.svelte.test.ts @@ -0,0 +1,137 @@ +// @vitest-environment jsdom + +import { afterEach, describe, expect, it, vi } from 'vitest'; + +import { createActiveDom } from '$adom'; +import { createActiveTimers } from '$timer'; +import { state } from '$libs/reactive'; +import type { Morfo } from '$uix/morfo'; +import { Soma } from '$soma/core/soma.svelte'; +import { createSomaRuntime, type SomaRuntimeSources } from '$soma/runtime.svelte'; +import { FloatingProvider } from '$soma/layers/floating'; + +import { ComboboxProvider } from './combobox-provider.svelte'; +import type { ComboboxType } from './types'; + +function withEffectRoot(fn: () => T): { result: T; cleanup: () => void } { + let result!: T; + const cleanup = $effect.root(() => { + result = fn(); + }); + return { result, cleanup }; +} + +function installSomaHarness() { + const dom = createActiveDom(); + const timers = createActiveTimers(); + const soma = { + dom, + uix: { timers }, + langs: { ts: (key: string) => key }, + runtime: (morfo: Morfo, sources: Omit) => + createSomaRuntime(morfo, { + dom, + translate: (key) => key, + ...sources + }) + } as unknown as Soma; + + vi.spyOn(Soma, 'require').mockReturnValue(soma); + vi.spyOn(ComboboxProvider.ctx, 'set').mockImplementation((value) => value); + vi.spyOn(FloatingProvider, 'create').mockReturnValue({} as FloatingProvider); + + return { dom, timers }; +} + +function createComboboxOpts() { + return { + id: state('combobox-root'), + ref: state(null), + open: state(true), + value: state([]), + inputValue: state(''), + type: state('single'), + disabled: state(false), + required: state(false), + name: state('choice'), + loop: state(false), + allowDeselect: state(false), + dir: state<'ltr' | 'rtl'>('ltr'), + onOpenChangeComplete: state(() => {}) + }; +} + +describe('ComboboxProvider', () => { + afterEach(() => { + vi.restoreAllMocks(); + document.body.innerHTML = ''; + }); + + it('selects, closes and resolves display labels in single-select mode', () => { + const { dom, timers } = installSomaHarness(); + const opts = createComboboxOpts(); + + const { result: provider, cleanup } = withEffectRoot(() => ComboboxProvider.create(opts)); + provider.registerLabel('a', 'Alpha'); + + provider.selectItem('a'); + + expect(opts.value.current).toEqual(['a']); + expect(opts.open.current).toBe(false); + expect(provider.getDisplayText()).toBe('Alpha'); + + opts.open.current = true; + opts.allowDeselect.current = true; + provider.selectItem('a'); + + expect(opts.value.current).toEqual([]); + expect(opts.open.current).toBe(false); + + cleanup(); + timers.dispose(); + dom.dispose(); + }); + + it('updates input value and toggles multiple selections without closing', () => { + const { dom, timers } = installSomaHarness(); + const opts = createComboboxOpts(); + opts.type.current = 'multiple'; + opts.value.current = ['a']; + + const { result: provider, cleanup } = withEffectRoot(() => ComboboxProvider.create(opts)); + + provider.updateInputValue('alp'); + expect(opts.inputValue.current).toBe('alp'); + + provider.selectItem('b'); + expect(opts.value.current).toEqual(['a', 'b']); + expect(opts.open.current).toBe(true); + + provider.selectItem('a'); + expect(opts.value.current).toEqual(['b']); + expect(opts.open.current).toBe(true); + + cleanup(); + timers.dispose(); + dom.dispose(); + }); + + it('filters disabled DOM items from navigation candidates', () => { + const { dom, timers } = installSomaHarness(); + const opts = createComboboxOpts(); + const container = document.createElement('div'); + container.innerHTML = ` +
+
+
+ `; + + const { result: provider, cleanup } = withEffectRoot(() => ComboboxProvider.create(opts)); + + expect(provider.getItems(container).map((el) => el.id)).toEqual(['a', 'c']); + + cleanup(); + timers.dispose(); + dom.dispose(); + }); +});