active-svelte

Commit Graph

Author	SHA1	Message	Date
dev	a01ef0f63d	Replace LOGGER_CATEGORY with <MOD>_MODULE single source of truth Phase 2B.1 of the convention pass. Establishes one canonical constant per module — `<MOD>_MODULE = '<alias>'` — as the single source for the module's identifier across logger category, error message prefixes, event scopes, and any other place the module's name is needed. What changed: 1. Renamed all `<MOD>_LOG_CATEGORY` constants to `<MOD>_MODULE` (the value semantics didn't change; only the name). Affected modules: buss, conn, sess, perm (libs+arts+svrs), timr, lang, auth, http, sium, cach, stor, aapp (libs+arts), and the four fmts sub-modules (fmts, fmts.curr, fmts.dates, fmts.nums, fmts.unts). 2. Aligned values with the 4-letter alias where they didn't already: - STOR_MODULE: 'storage' → 'stor' - FMTS_MODULE: 'formats' → 'fmts' - FMTS_CURR_MODULE: 'formats.currency' → 'fmts.curr' - FMTS_DATES_MODULE: 'formats.dates' → 'fmts.dates' - FMTS_NUMS_MODULE: 'formats.numbers' → 'fmts.nums' - FMTS_UNTS_MODULE: 'formats.units' → 'fmts.unts' 3. Unified the duplicate `AAPP_MODULE` declaration: arts/aapp/consts.ts now re-exports from libs/aapp/consts.ts (canonical source). Both files used to declare it independently with different values ('app' vs 'aapp'). 4. Replaced hardcoded `'[<alias>] ...'` literals in error messages with template strings using `<MOD>_MODULE`. Every error-message constant now derives the prefix from the module identifier instead of hardcoding it. Affected files: libs/aapp/consts.ts, arts/aapp/consts.ts, libs/buss/consts.ts, libs/lang/errors.ts, arts/stor/errors.ts, arts/sium/errors.ts, arts/fmts/errors.ts, and the ERROR_PREFIX constants in arts/conn, arts/sess, arts/http, arts/timr. 5. Updated diagnostic event values to use the new module aliases: - STOR_DIAGNOSTIC_EVENTS.ERROR: 'storage.error' → 'stor.error' - All FMTS__DIAGNOSTIC_EVENTS values to use 'fmts.X.' 6. Updated tests that asserted against the old values (storage-integration.test and fmts/curr/test/barrel.test). 7. Updated docs/conventions.md: replaced the LOG_CATEGORY category with the new MODULE category. Added the rule that ERROR_MSG values must use the template `[${<MOD>_MODULE}]`, never a hardcoded literal. Verification: svelte-check 1395 / 0 errors. Server 1230 tests, client 19 tests — all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	5 months ago
dev	6908f82f09	Reorganize docs: move working/audit files to docs/ and add conventions Working documents and audits were spread across the project root, mixing with standard npm/GitHub files (README, CHANGELOG, CONTRIBUTING, SECURITY, BRAND). Moves them under docs/ for a clean root and adds docs/conventions.md as the canonical document for codebase-wide naming and structure rules. Files moved to docs/ (via git mv, history preserved): - audit-1-5.md (current ecosystem audit) - AUDIT_KIMI.md - AUDIT_OPENCODE.md - AUDIT_claude.md (historical audits from prior tools) - before_0_1.md (pre-0.1 release checklist) - buss.md (bus design doc, no longer live) - NEXT_STEPS.md (roadmap) Files staying in root (npm/GitHub convention): - README.md, CHANGELOG.md, CONTRIBUTING.md, SECURITY.md, BRAND.md References updated to point at docs/: - CHANGELOG.md (line 11) - README.md (line 105) - SECURITY.md (line 3) - src/web/routes/active/security/+page.svelte (line 46) docs/conventions.md captures three rules accepted as binding for the codebase: 1. Module identifier — every artifact and lib uses its 4-letter alias (BUSS, CONN, SESS, PERM, TIMR, LOGR, CACH, STOR, FMTS, FEND, ADOM, AAPP, AUTH, LANG, HTTP, SIUM, ERRS) for both string values and constant name prefixes. Drift from this rule (BUS_, CONNECTION_, SESSION_, …) is being closed in the next audit pass. 2. Constant naming — `<MOD>_<CATEGORY>_<NAME>` strictly. No exceptions (no DEFAULT_TIMER_ style). 3. Category vocabulary — fixed list of category tokens (ERR, EVENT, DIAGNOSTIC_EVENTS, METHOD, STATE, STATUS, KIND, REASON, TYPE, MODE, DEFAULT, LIMIT, ID_PREFIX, LOG_CATEGORY, LOG_MSG, ERROR_MSG, ERROR_NAME, CONTEXT_KEY). Ad-hoc categories (AUTO_REAUTH, AUTO_INVALIDATE, BUFFER_POLICY, CHANNEL_STATE) fold into one of these. The document also formalizes the layer rules and ErrCode shape that will be implemented in upcoming commits. svelte-check 1395/0 errors. No code-side regressions; the moves are file-only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	5 months ago

Author

SHA1

Message

Date

dev

a01ef0f63d

Replace LOGGER_CATEGORY with <MOD>_MODULE single source of truth

Phase 2B.1 of the convention pass. Establishes one canonical constant
per module — `<MOD>_MODULE = '<alias>'` — as the single source for the
module's identifier across logger category, error message prefixes,
event scopes, and any other place the module's name is needed.

What changed:

1. Renamed all `<MOD>_LOG_CATEGORY` constants to `<MOD>_MODULE` (the
   value semantics didn't change; only the name). Affected modules:
   buss, conn, sess, perm (libs+arts+svrs), timr, lang, auth, http,
   sium, cach, stor, aapp (libs+arts), and the four fmts sub-modules
   (fmts, fmts.curr, fmts.dates, fmts.nums, fmts.unts).

2. Aligned values with the 4-letter alias where they didn't already:
   - STOR_MODULE: 'storage' → 'stor'
   - FMTS_MODULE: 'formats' → 'fmts'
   - FMTS_CURR_MODULE: 'formats.currency' → 'fmts.curr'
   - FMTS_DATES_MODULE: 'formats.dates' → 'fmts.dates'
   - FMTS_NUMS_MODULE: 'formats.numbers' → 'fmts.nums'
   - FMTS_UNTS_MODULE: 'formats.units' → 'fmts.unts'

3. Unified the duplicate `AAPP_MODULE` declaration: arts/aapp/consts.ts
   now re-exports from libs/aapp/consts.ts (canonical source). Both
   files used to declare it independently with different values
   ('app' vs 'aapp').

4. Replaced hardcoded `'[<alias>] ...'` literals in error messages
   with template strings using `<MOD>_MODULE`. Every error-message
   constant now derives the prefix from the module identifier instead
   of hardcoding it. Affected files: libs/aapp/consts.ts, arts/aapp/consts.ts,
   libs/buss/consts.ts, libs/lang/errors.ts, arts/stor/errors.ts,
   arts/sium/errors.ts, arts/fmts/errors.ts, and the ERROR_PREFIX
   constants in arts/conn, arts/sess, arts/http, arts/timr.

5. Updated diagnostic event values to use the new module aliases:
   - STOR_DIAGNOSTIC_EVENTS.ERROR: 'storage.error' → 'stor.error'
   - All FMTS_*_DIAGNOSTIC_EVENTS values to use 'fmts.X.*'

6. Updated tests that asserted against the old values (storage-integration.test
   and fmts/curr/test/barrel.test).

7. Updated docs/conventions.md: replaced the LOG_CATEGORY category
   with the new MODULE category. Added the rule that ERROR_MSG values
   must use the template `[${<MOD>_MODULE}]`, never a hardcoded literal.

Verification: svelte-check 1395 / 0 errors. Server 1230 tests, client
19 tests — all green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

dev

6908f82f09

Reorganize docs: move working/audit files to docs/ and add conventions

Working documents and audits were spread across the project root,
mixing with standard npm/GitHub files (README, CHANGELOG, CONTRIBUTING,
SECURITY, BRAND). Moves them under docs/ for a clean root and adds
docs/conventions.md as the canonical document for codebase-wide
naming and structure rules.

Files moved to docs/ (via git mv, history preserved):
- audit-1-5.md           (current ecosystem audit)
- AUDIT_KIMI.md
- AUDIT_OPENCODE.md
- AUDIT_claude.md         (historical audits from prior tools)
- before_0_1.md           (pre-0.1 release checklist)
- buss.md                 (bus design doc, no longer live)
- NEXT_STEPS.md           (roadmap)

Files staying in root (npm/GitHub convention):
- README.md, CHANGELOG.md, CONTRIBUTING.md, SECURITY.md, BRAND.md

References updated to point at docs/:
- CHANGELOG.md             (line 11)
- README.md                (line 105)
- SECURITY.md              (line 3)
- src/web/routes/active/security/+page.svelte (line 46)

docs/conventions.md captures three rules accepted as binding for the
codebase:

1. Module identifier — every artifact and lib uses its 4-letter alias
   (BUSS, CONN, SESS, PERM, TIMR, LOGR, CACH, STOR, FMTS, FEND, ADOM,
   AAPP, AUTH, LANG, HTTP, SIUM, ERRS) for both string values and
   constant name prefixes. Drift from this rule (BUS_*, CONNECTION_*,
   SESSION_*, …) is being closed in the next audit pass.
2. Constant naming — `<MOD>_<CATEGORY>_<NAME>` strictly. No
   exceptions (no DEFAULT_TIMER_* style).
3. Category vocabulary — fixed list of category tokens (ERR, EVENT,
   DIAGNOSTIC_EVENTS, METHOD, STATE, STATUS, KIND, REASON, TYPE, MODE,
   DEFAULT, LIMIT, ID_PREFIX, LOG_CATEGORY, LOG_MSG, ERROR_MSG,
   ERROR_NAME, CONTEXT_KEY). Ad-hoc categories (AUTO_REAUTH,
   AUTO_INVALIDATE, BUFFER_POLICY, CHANNEL_STATE) fold into one of
   these.

The document also formalizes the layer rules and ErrCode shape that
will be implemented in upcoming commits.

svelte-check 1395/0 errors. No code-side regressions; the moves are
file-only.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2 Commits (a01ef0f63d430e7a32ccf58a58248642de9ef2af)